Skip to content

Improve the prompts#283

Merged
StephanAkkerman merged 20 commits into
mainfrom
feat/prompt-improv
Jun 13, 2025
Merged

Improve the prompts#283
StephanAkkerman merged 20 commits into
mainfrom
feat/prompt-improv

Conversation

@StephanAkkerman

Copy link
Copy Markdown
Owner

Description

This PR [adds/removes/fixes/replaces] the [feature/bug/etc].

Related Tickets & Documents

Fixes # (issue)

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Added to documentation?

  • 📜 README.md
  • 📓 Wiki
  • 🙅 No documentation needed

@StephanAkkerman StephanAkkerman marked this pull request as ready for review June 11, 2025 18:53

@code-review-doctor code-review-doctor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some food for thought. View full project report here.

Comment thread backend/mnemorai/utils/syllabifier.py Outdated
StephanAkkerman and others added 3 commits June 11, 2025 20:53
Co-authored-by: code-review-doctor[bot] <72320148+code-review-doctor[bot]@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors prompt generation and model configuration, adds new utilities for syllabification and n-gram probabilities, and updates dependencies and pipelines.

  • Updated config.yaml with new LLM/IMAGE_GEN model names and parameters, including FLUX LoRA settings
  • Expanded requirements.txt with language‐processing libraries and platform‐specific Nunchaku wheels
  • Introduced syllabifier.py and ngram_probs.py; refactored VerbalCue and ImageGen services for improved prompt templates and FLUX integration

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
config.yaml Swapped model names; added MNEMONIC_CANDIDATES, params
backend/requirements.txt Downgraded transformers; added pyphen/lingpy/epitran, nunchaku wheels
backend/mnemorai/utils/syllabifier.py New language syllabification utility
backend/mnemorai/utils/ngram_probs.py New n-gram probability utility with corpus downloads
backend/mnemorai/services/pre/translator.py Improved logging around language code mapping
backend/mnemorai/services/imagine/verbal_cue_gen.py Refactored mnemonic/verbal-cue prompt templates
backend/mnemorai/services/imagine/image_gen.py Replaced SanaPipeline with FLUXPipeline; seed & offload logic
backend/mnemorai/run.py Updated example invocation
Comments suppressed due to low confidence (3)

config.yaml:33

  • Ensure that MNEMONIC_CANDIDATES is correctly indented under the LLM section and consider documenting this new parameter in the README so users know how to adjust it.
MNEMONIC_CANDIDATES: 20

backend/mnemorai/services/imagine/image_gen.py:57

  • The old SanaPipeline branch was removed; ensure that any users or docs referencing Sana pipelines are updated and that the default branch (AutoPipelineForText2Image) still covers all intended models.
if "flux" in self.model_name.lower():

backend/requirements.txt:4

  • Downgrading Transformers from 4.52.4 to 4.51.3 may reintroduce bugs or security issues; please confirm that this change is intentional and update any related compatibility tests or documentation.
transformers[sentencepiece]==4.51.3

Comment thread backend/mnemorai/utils/ngram_probs.py
Comment thread backend/mnemorai/services/pre/translator.py
@StephanAkkerman StephanAkkerman merged commit a5c811e into main Jun 13, 2025
7 checks passed
@StephanAkkerman StephanAkkerman deleted the feat/prompt-improv branch June 13, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants