Skip to content

feat(plugin): declare TMDB image resolver capability#4

Merged
Quick104 merged 1 commit into
mainfrom
codex/image-resolver-capability
Jun 25, 2026
Merged

feat(plugin): declare TMDB image resolver capability#4
Quick104 merged 1 commit into
mainfrom
codex/image-resolver-capability

Conversation

@Quick104

@Quick104 Quick104 commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Part of Silo-Server/silo-server#135.

Summary

  • add explicit image_resolver.v1 capability for the tmdb scheme
  • register the existing metadata server as the ImageResolver service
  • keep metadata-provider image RPCs for older server compatibility
  • bump silo-plugin-sdk to v0.8.1

Verification

  • go test ./...

AI use

Implemented with Codex.

Summary by CodeRabbit

  • New Features

    • Added image resolution support for TMDB images.
    • The plugin now advertises an additional image-related capability alongside existing metadata support.
  • Chores

    • Updated the plugin version.
    • Bumped the required plugin SDK version for compatibility with the latest changes.

@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 2b482540-4257-47af-8767-2370369b9e4d

📥 Commits

Reviewing files that changed from the base of the PR and between f9c35e4 and 0f768ea.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (3)
  • go.mod
  • main.go
  • manifest.json

📝 Walkthrough

Walkthrough

The PR updates the plugin SDK and manifest, adds an image_resolver.v1 TMDB capability, and wires metadataServer to serve both metadata and image-resolution requests.

Changes

TMDB image resolver capability

Layer / File(s) Summary
Capability manifest and SDK bump
go.mod, manifest.json
github.com/Silo-Server/silo-plugin-sdk is updated to v0.8.1, the plugin version changes to 1.2.17, and image_resolver.v1 is added for TMDB images with tmdb scheme metadata and priority 100.
Image resolver server wiring
main.go
metadataServer embeds UnimplementedImageResolverServer, and main() registers one shared instance for both MetadataProvider and ImageResolver.

Sequence Diagram(s)

sequenceDiagram
  participant main as main()
  participant runtime as runtime.Serve
  participant ms as metadataServer
  main->>ms: construct shared instance
  main->>runtime: configure MetadataProvider = ms
  main->>runtime: configure ImageResolver = ms
  runtime->>ms: dispatch MetadataProvider requests
  runtime->>ms: dispatch ImageResolver requests
Loading

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately captures the main change: declaring the TMDB image resolver capability.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/image-resolver-capability

Comment @coderabbitai help to get the list of available commands.

@Quick104 Quick104 merged commit ac3cfdc into main Jun 25, 2026
6 of 7 checks passed
@Quick104 Quick104 deleted the codex/image-resolver-capability branch June 25, 2026 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant