Skip to content

adding MAX31856 support#56

Open
yoxcu wants to merge 4 commits into
Saur0o0n:masterfrom
yoxcu:max31856
Open

adding MAX31856 support#56
yoxcu wants to merge 4 commits into
Saur0o0n:masterfrom
yoxcu:max31856

Conversation

@yoxcu

@yoxcu yoxcu commented Aug 28, 2025

Copy link
Copy Markdown

This adds MAX31856 support, the module supports different types of thermocouple.
By defining any TCTYPE (K,J,S,...) in PIDKiln.h

#define MAXTYPE1 MAX31856_TCTYPE_J

adafruit_max31856 lib is imported for reading the temperatures.

@Saur0o0n

Copy link
Copy Markdown
Owner

I took a quick look - have to think on it. I'm not a huge fan of this many #ifs - especially big #ifs in termocouple readout function. Perhaps it would be better somehow to create single function for each thermocouple type and as parameter just make it read A or B thermoucouple - and call proper one. Or even dedicated files for each max types and use only one.. just thinking out loud...

@yoxcu

yoxcu commented Aug 28, 2025

Copy link
Copy Markdown
Author

yup did not want to change too much code wise.
8171d65 seperates the code of both boards into two .inos. this should also make it easier to add different boards.
I only have MAX31856 available for testing, this works. I also tried mixing 55 and 56 which also worked as expected (55 threw an error 5 times and program aborted)

@yoxcu

yoxcu commented Aug 28, 2025

Copy link
Copy Markdown
Author

also is it by design that the int_temp is the mean over both TC CJ?

@ajunca

ajunca commented Dec 10, 2025

Copy link
Copy Markdown

Hi, I'm also interested on this feature. What is the state and what needs to be done to be approved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants