Skip to content

Fix GCC 14 -Wstringop-overflow warnings on ppc64le #1077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
runlevel5 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix GCC 14 -Wstringop-overflow warnings on ppc64le #1077

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion neo/d3xp/gamesys/SysCmds.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1439,7 +1439,8 @@ static void PrintFloat( float f )
char buf[128];
int i;

for( i = idStr::snPrintf( buf, sizeof( buf ), "%3.2f", f ); i < 7; i++ )
// snPrintf() returns >= 0 here, cast to uint to avoid false positive -Wstringop-overflow
for( i = ( unsigned int )idStr::snPrintf( buf, sizeof( buf ), "%3.2f", f ); i < 7; i++ )
{
buf[i] = ' ';
}
Expand Down
10 changes: 5 additions & 5 deletions neo/idlib/Swap.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,21 +82,21 @@ class idSwap
// byte swapping pointers is pointless because we should never store pointers on disk
assert( !IsPointer( c ) );

if( sizeof( type ) == 1 )
if constexpr( sizeof( type ) == 1 )
{
}
else if( sizeof( type ) == 2 )
else if constexpr( sizeof( type ) == 2 )
{
byte* b = ( byte* )&c;
SwapBytes( b[0], b[1] );
}
else if( sizeof( type ) == 4 )
else if constexpr( sizeof( type ) == 4 )
{
byte* b = ( byte* )&c;
SwapBytes( b[0], b[3] );
SwapBytes( b[1], b[2] );
}
else if( sizeof( type ) == 8 )
else if constexpr( sizeof( type ) == 8 )
{
byte* b = ( byte* )&c;
SwapBytes( b[0], b[7] );
Expand All @@ -106,7 +106,7 @@ class idSwap
}
else
{
assert( false );
static_assert( sizeof( type ) == 0, "unsupported type size for byte swapping" );
}
}

Expand Down