feat(integrations): AutoGen adapter + integration CI; fix broken crewai/langgraph adapters (Phase 1, Week 3-4)#170
Merged
Conversation
…adapters Roadmap Phase 1, Week 3-4: Framework Adapters. New: AutoGen (AG2 / autogen-core v0.4+) adapter - mimir_autogen.MimirMemory implements the autogen_core.memory.Memory protocol (add/query/update_context/clear/close), maps MemoryContent onto Mimir entities, injects mimir_context as a SystemMessage before each turn - Persistent stdio session, pyproject, README, 7 passing tests (framework stubbed) Fixes uncovered while adding CI (no CI ran the Python tests before): - crewai + langgraph: init handshake read the wrong JSON-RPC id (req_id-1=0 vs init id 1), causing a 30s stall on every real session start. Now reads init_id - crewai + langgraph tests: FakePopen still used the old communicate() API after the adapters moved to persistent write/readline stdio — every test errored with 'FakePopen has no attribute stdin'. Rewrote both fakes to drive the stdio session - langgraph adapter passed nonexistent --ollama-url and misused --embedding-model (expects an ONNX path, not a model name). Now maps to --llm-endpoint/--llm-model New CI: .github/workflows/integrations.yml — matrix-tests all three adapters (autogen, crewai, langgraph) on every integrations/** change. langgraph installs the real package since it imports langgraph.store.base at module load. Verified: 7 (autogen) + 3 (crewai) + 6 (langgraph) = 16 tests passing locally.
There was a problem hiding this comment.
Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.
Once credits are available, push a new commit or reopen this pull request to trigger a review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Roadmap Phase 1, Week 3-4: Framework Adapters. Completes the third adapter (AutoGen) and hardens the existing two.
New: AutoGen adapter (
integrations/autogen/)mimir_autogen.MimirMemoryimplements theautogen_core.memory.Memoryprotocol (AG2 / autogen-core v0.4+):add→mimir_remember,query→mimir_recall,update_contextinjects amimir_contextblock as aSystemMessage,clear→mimir_prune,closereaps the processMemoryContent↔ Mimir entities; persistent stdio session (spawn-once)pyproject.toml,README.md, and 7 passing tests (framework deps stubbed)Fixes uncovered while wiring CI
No CI ran the Python integration tests before, so these were silently broken on main:
req_id - 1(= 0) butinitializeused id1, so_read_responsebusy-waited the full 30s timeout on every real session start. Now reads the correctinit_id.FakePopenstill used the oldcommunicate()API after the adapters moved to persistentwrite/readlinestdio — every test errored withFakePopen has no attribute 'stdin'. Rewrote both fakes to drive the stdio session.--ollama-urland misused--embedding-model(which expects an ONNX model path, not a name). Now mapsollama_url→--llm-endpointandembedding_model→--llm-model.New CI:
.github/workflows/integrations.ymlMatrix-tests all three adapters (autogen, crewai, langgraph) on every
integrations/**change. langgraph installs the real package because it importslanggraph.store.baseat module load.Verification
All 16 tests green locally.