Skip to content

feat(integrations): AutoGen adapter + integration CI; fix broken crewai/langgraph adapters (Phase 1, Week 3-4)#170

Merged
tcconnally merged 1 commit into
mainfrom
feat/autogen-adapter-and-integration-ci
Jun 20, 2026
Merged

feat(integrations): AutoGen adapter + integration CI; fix broken crewai/langgraph adapters (Phase 1, Week 3-4)#170
tcconnally merged 1 commit into
mainfrom
feat/autogen-adapter-and-integration-ci

Conversation

@tcconnally

Copy link
Copy Markdown
Collaborator

Roadmap Phase 1, Week 3-4: Framework Adapters. Completes the third adapter (AutoGen) and hardens the existing two.

New: AutoGen adapter (integrations/autogen/)

mimir_autogen.MimirMemory implements the autogen_core.memory.Memory protocol (AG2 / autogen-core v0.4+):

  • addmimir_remember, querymimir_recall, update_context injects a mimir_context block as a SystemMessage, clearmimir_prune, close reaps the process
  • Maps MemoryContent ↔ Mimir entities; persistent stdio session (spawn-once)
  • pyproject.toml, README.md, and 7 passing tests (framework deps stubbed)

Fixes uncovered while wiring CI

No CI ran the Python integration tests before, so these were silently broken on main:

  • init handshake id bug (crewai + langgraph): the init response was read with req_id - 1 (= 0) but initialize used id 1, so _read_response busy-waited the full 30s timeout on every real session start. Now reads the correct init_id.
  • broken test doubles (crewai + langgraph): FakePopen still used the old communicate() API after the adapters moved to persistent write/readline stdio — every test errored with FakePopen has no attribute 'stdin'. Rewrote both fakes to drive the stdio session.
  • wrong CLI flags (langgraph): adapter passed a nonexistent --ollama-url and misused --embedding-model (which expects an ONNX model path, not a name). Now maps ollama_url--llm-endpoint and embedding_model--llm-model.

New CI: .github/workflows/integrations.yml

Matrix-tests all three adapters (autogen, crewai, langgraph) on every integrations/** change. langgraph installs the real package because it imports langgraph.store.base at module load.

Verification

autogen   7 passed
crewai    3 passed
langgraph 6 passed

All 16 tests green locally.

…adapters

Roadmap Phase 1, Week 3-4: Framework Adapters.

New: AutoGen (AG2 / autogen-core v0.4+) adapter
- mimir_autogen.MimirMemory implements the autogen_core.memory.Memory protocol
  (add/query/update_context/clear/close), maps MemoryContent onto Mimir entities,
  injects mimir_context as a SystemMessage before each turn
- Persistent stdio session, pyproject, README, 7 passing tests (framework stubbed)

Fixes uncovered while adding CI (no CI ran the Python tests before):
- crewai + langgraph: init handshake read the wrong JSON-RPC id (req_id-1=0 vs
  init id 1), causing a 30s stall on every real session start. Now reads init_id
- crewai + langgraph tests: FakePopen still used the old communicate() API after
  the adapters moved to persistent write/readline stdio — every test errored with
  'FakePopen has no attribute stdin'. Rewrote both fakes to drive the stdio session
- langgraph adapter passed nonexistent --ollama-url and misused --embedding-model
  (expects an ONNX path, not a model name). Now maps to --llm-endpoint/--llm-model

New CI: .github/workflows/integrations.yml — matrix-tests all three adapters
(autogen, crewai, langgraph) on every integrations/** change. langgraph installs
the real package since it imports langgraph.store.base at module load.

Verified: 7 (autogen) + 3 (crewai) + 6 (langgraph) = 16 tests passing locally.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Code review skipped — your organization's overage spend limit has been reached.

Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.

Once credits are available, push a new commit or reopen this pull request to trigger a review.

@tcconnally tcconnally merged commit 1171055 into main Jun 20, 2026
5 checks passed
@tcconnally tcconnally deleted the feat/autogen-adapter-and-integration-ci branch July 2, 2026 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant