fix: isolate scraper failures so one crash doesn't break community search (#106)#107
Merged
PandyaJeet merged 1 commit intoJun 25, 2026
Conversation
…arch (PandyaJeet#106) asyncio.gather without return_exceptions=True propagates the first exception from any scraper, causing the entire /api/search/community endpoint to return 500. Added return_exceptions=True and replaced failed scraper results with empty lists so working sources still return data.
itsdakshjain
approved these changes
Jun 20, 2026
itsdakshjain
left a comment
itsdakshjain
left a comment
Contributor
There was a problem hiding this comment.
looks good third party scrapers arerisky, so using return_exceptions=True is the perfect move to stop a single crash from killing the whole endpoint.
but here you loop through the results to log the errors, but then manually do four separate if isinstance checks right after to reset the variables. you could actually handle the logging and the fallback assignment all inside that same loop to cut down on the repetitive code.
its optional rest all look good to merge @PandyaJeet
PandyaJeet
approved these changes
Jun 25, 2026
PandyaJeet
added
level:beginner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #106
Summary
asyncio.gatherwithoutreturn_exceptions=Truepropagates the first exception from any scraper, causing the entire/api/search/communityendpoint to return 500.Change: Added
return_exceptions=Truetoasyncio.gatherand replaced any failed scraper result with an empty list. Working scrapers still return data even when others fail.Type of Change