Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix SSRF Mitigation Bypass via IPv6 Assignment#451

Closed
Oxygen-Low wants to merge 1 commit into
mainfrom
fix-ssrf-ipv6-rebinding-9457123651598343525
Closed

πŸ›‘οΈ Sentinel: [CRITICAL] Fix SSRF Mitigation Bypass via IPv6 Assignment#451
Oxygen-Low wants to merge 1 commit into
mainfrom
fix-ssrf-ipv6-rebinding-9457123651598343525

Conversation

@Oxygen-Low

Copy link
Copy Markdown
Owner

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: In Node.js, attempting to set url.hostname = ipAddress fails silently when ipAddress is an unbracketed IPv6 address (e.g., 2606:4700::1111). This flaw bypassed our DNS rebinding mitigation in server/lib/safeAiUrl.ts, leaving the original malicious hostname intact and allowing an attacker to perform SSRF attacks by pointing a domain to an internal IPv6 address.
🎯 Impact: Attackers could bypass SSRF protections and target internal services using IPv6 addresses.
πŸ”§ Fix: Wrapped the resolved IP address in brackets [] using net.isIPv6() before assignment, ensuring the url.hostname setter applies it successfully.
βœ… Verification: pnpm test and pnpm typecheck passed successfully with no regressions.


PR created automatically by Jules for task 9457123651598343525 started by @Oxygen-Low

Co-authored-by: Oxygen-Low <95589118+Oxygen-Low@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@Oxygen-Low, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 34 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
βš™οΈ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: c982aae4-db45-453e-8e88-fa3026078b5a

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between 353a85c and 874b67d.

β›” Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
πŸ“’ Files selected for processing (4)
  • .jules/sentinel.md
  • client/hooks/useFont.ts
  • client/pages/Apps.tsx
  • server/lib/safeAiUrl.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share

Comment @coderabbitai help to get the list of available commands.

@Oxygen-Low Oxygen-Low closed this Jul 17, 2026
@Oxygen-Low
Oxygen-Low deleted the fix-ssrf-ipv6-rebinding-9457123651598343525 branch July 17, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant