Skip to content

feat: session-aware game-skill + OCP playback#428

Open
JarbasAl wants to merge 1 commit into
devfrom
feat/gameskill-and-ocp-deprecation
Open

feat: session-aware game-skill + OCP playback#428
JarbasAl wants to merge 1 commit into
devfrom
feat/gameskill-and-ocp-deprecation

Conversation

@JarbasAl

Copy link
Copy Markdown
Member

Split out from #427. Stacked on #427 (feat/intent-layers-context) — merge that first.

488 tests pass locally.

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@JarbasAl, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 24 minutes and 47 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more credits in the billing tab to continue.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: abb675de-a948-4355-80f2-83acfbd12042

📥 Commits

Reviewing files that changed from the base of the PR and between e4ef6f7 and 7473e2d.

📒 Files selected for processing (4)
  • ovos_workshop/skills/common_play.py
  • ovos_workshop/skills/game_skill.py
  • test/unittests/skills/test_common_play_extended.py
  • test/unittests/skills/test_game_skill_extended.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/gameskill-and-ocp-deprecation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@JarbasAl JarbasAl force-pushed the feat/gameskill-and-ocp-deprecation branch from 64c35d7 to f776228 Compare June 26, 2026 01:38
@JarbasAl JarbasAl changed the base branch from feat/intent-layers-context to dev June 26, 2026 02:32
@github-actions github-actions Bot added feature and removed feature labels Jun 26, 2026
Per-session playback state in OVOSCommonPlaybackSkill (state events emit via
message.reply so they route to the originating session) and game_skill on the
context-gated layers (probing skill_will_match with its session). OCPCommonPlayback
deprecation is handled in #423.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@JarbasAl JarbasAl force-pushed the feat/gameskill-and-ocp-deprecation branch from f776228 to 7473e2d Compare June 26, 2026 02:37
@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Hey! I've got some fresh data on your pull request. 📈

I've aggregated the results of the automated checks for this PR below.

🔍 Lint

I've checked the pulse of your pull request. 💓

ruff: issues found — see job log

📋 Repo Health

Checking the repo's mental health (aka developer happiness). 😊

✅ All required files present.

Latest Version: 9.0.0a1

ovos_workshop/version.py — Version file
README.md — README
LICENSE — License file
pyproject.toml — pyproject.toml
⚠️ setup.py — setup.py
CHANGELOG.md — Changelog
ovos_workshop/version.py has valid version block markers

⚖️ License Check

Ensuring no copyleft violations in this PR. ⬅️

✅ No license violations found.

Policy: Apache 2.0 (universal donor). StrongCopyleft / NetworkCopyleft / WeakCopyleft / Other / Error categories fail. MPL allowed.

🔒 Security (pip-audit)

Checking if we're following security best practices. 📏

✅ No known vulnerabilities found (72 packages scanned).

🔨 Build Tests

The compiler has spoken! Here is the verdict. 📜

Python Build Install Tests
3.10
3.11
3.12
3.13
3.14

❌ 3.10: Build OK, install failed
❌ 3.11: Build OK, install failed
❌ 3.12: Build OK, install failed
❌ 3.13: Build OK, install failed
❌ 3.14: Build OK, install failed
Check job logs for details.


The silent guardian of the dev branch. 🦇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant