PIPELINE-1: required_slots backstop, reserve fallback/common_query, listen field#66
Draft
JarbasAl wants to merge 1 commit into
Draft
PIPELINE-1: required_slots backstop, reserve fallback/common_query, listen field#66JarbasAl wants to merge 1 commit into
JarbasAl wants to merge 1 commit into
Conversation
1204568 to
d47ed79
Compare
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
303b7f3 to
2c42e43
Compare
2c42e43 to
c61a19c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidates the
ovos-pipeline-1.mdcompanion edits previously bundled into the union-slots (#56), FALLBACK-1 (#39), COMMON-QUERY-1 (#40) and AUDIO-1 (#38) feature PRs into a single one-file change — per the 1 file, 1 PR rule.Changes
required_slots(INTENT-3 §5.3): after a plugin returns a Match, the orchestrator MUST treat it as declined if any required slot is absent. Second line of defense behind engine-sidematch()enforcement.fallback(FALLBACK-1 §6.3) andcommon_query(COMMON-QUERY-1 §3). COMMON-QUERY-1 asserted the reservation but never added the registry row — this closes that gap.listenfield toovos.utterance.speak; the output-side behaviour is owned by AUDIO-1.Compatibility: all additions are backwards-compatible. PIPELINE-1 is already V2 (its namespaced topics replace pre-spec names); these refinements don't change the class, so Version stays 2.
#56 / #39 / #40 / #38 drop their pipeline-1 companion edits and forward-reference this PR.