Skip to content

Add CLI init template generation#167

Merged
segsell merged 7 commits into
mainfrom
cli_init
May 20, 2025
Merged

Add CLI init template generation#167
segsell merged 7 commits into
mainfrom
cli_init

Conversation

@gregor-schueler

Copy link
Copy Markdown
Collaborator

Note: The sparsity_condition function in the full model is not JIT-compatible because:

  • It uses Python control flow (if/or) with JAX arrays
  • It returns inconsistent types (bool vs dict)

As a result, the simulate method in the full model will fail under jax.jit.

We may need to:

  • Rewrite sparsity_condition using jax.lax.cond and consistent output types, or
  • Skip JIT for methods that rely on this logic

  • need to update the jupyter notebook for full model

@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Comment thread src/dcegm/templates/fullmodel/run_example.py
@codecov

codecov Bot commented May 20, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.72%. Comparing base (83037d3) to head (4803db5).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #167      +/-   ##
==========================================
- Coverage   95.87%   95.72%   -0.15%     
==========================================
  Files          68       61       -7     
  Lines        1768     1685      -83     
==========================================
- Hits         1695     1613      -82     
+ Misses         73       72       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@segsell segsell self-requested a review May 20, 2025 11:35
@segsell segsell merged commit 99c4930 into main May 20, 2025
7 checks passed
@segsell segsell deleted the cli_init branch May 20, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants