Skip to content

Prepare retreat#162

Merged
MaxBlesch merged 3 commits into
mainfrom
prep_retreat
May 19, 2025
Merged

Prepare retreat#162
MaxBlesch merged 3 commits into
mainfrom
prep_retreat

Conversation

@MaxBlesch

@MaxBlesch MaxBlesch commented May 16, 2025

Copy link
Copy Markdown
Member

This PR prepares the DCEGM retreat. There are mainly three things we want to fix.

  • Rewrite model_sim keyword to alt_model_funcs
  • Move to params, model_specs (options["model_params"] before) and model_config (options["state_space"] before)
  • Introduce classes for the interface.

The first changes are directly developed here. The second and third will have their own PR with this branch as base branch.

@codecov

codecov Bot commented May 16, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.33611% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.86%. Comparing base (10ddc4f) to head (68d46f2).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
src/dcegm/pre_processing/check_options.py 92.75% 5 Missing ⚠️
src/dcegm/pre_processing/batches/batch_creation.py 77.77% 2 Missing ⚠️
src/dcegm/interfaces/sol_interface.py 95.00% 1 Missing ⚠️
.../dcegm/pre_processing/alternative_sim_functions.py 96.55% 1 Missing ⚠️
...oy_models/example_params_model_specs_and_config.py 97.22% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #162      +/-   ##
==========================================
+ Coverage   94.18%   95.86%   +1.68%     
==========================================
  Files          60       68       +8     
  Lines        1633     1766     +133     
==========================================
+ Hits         1538     1693     +155     
+ Misses         95       73      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Co-authored-by: Sebastian Gsell <sebastian.gsell93@gmail.com>
Co-authored-by: Annica Gehlen <39128048+amageh@users.noreply.github.com>
@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@MaxBlesch MaxBlesch requested a review from segsell May 19, 2025 22:26
@MaxBlesch MaxBlesch merged commit 5eb5eaf into main May 19, 2025
@MaxBlesch MaxBlesch deleted the prep_retreat branch May 19, 2025 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants