fix awkward layout bugs

[NielsPilgaard]

No description provided.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The PR removes the FirstLogin query parameter logic from account authentication flows (Login, ExternalLogin, ConfirmEmail) and MainLayout component. It also consolidates snackbar message handling across search pages by adding clear calls before displaying new notifications and removing explicit key parameters. Minor layout and styling refinements are applied to chat and landing pages.

Changes

Cohort / File(s)	Summary
FirstLogin Parameter Removal src/web/Jordnaer/Components/Account/Pages/ConfirmEmail.razor, src/web/Jordnaer/Components/Account/Pages/ExternalLogin.razor, src/web/Jordnaer/Components/Account/Pages/Login.razor, src/web/Jordnaer/Pages/Shared/MainLayout.razor	Removes FirstLogin query parameter from redirect URLs and removes FirstLogin property and OnInitialized welcome snackbar logic from MainLayout. Default redirects now use base URLs without query parameters.
Snackbar Message Handling src/web/Jordnaer/Pages/GroupSearch/GroupSearch.razor, src/web/Jordnaer/Pages/Posts/Posts.razor, src/web/Jordnaer/Pages/UserSearch/UserSearch.razor	Adds Snackbar.Clear() before displaying new notifications and removes explicit key parameter from Snackbar.Add calls across search result handlers.
Layout & Styling Updates src/web/Jordnaer/Pages/Chat/ChatPage.razor, src/web/Jordnaer/Pages/Home/DesktopLandingPage.razor, src/web/Jordnaer/Pages/Home/MobileLandingPage.razor, src/web/Jordnaer/wwwroot/css/chat.css	Adds full-width CSS styling to ChatPage, adds horizontal center alignment to DesktopLandingPage grid, wraps "Del oplevelser" block with Posts feature flag gate in MobileLandingPage, and changes chat message list height from min-height to height.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

• Account flow changes: Verify that removing FirstLogin parameters from redirect URLs aligns with authentication flow requirements and doesn't break first-time user onboarding
• Snackbar modifications: Confirm that clearing snackbar state before each search operation is consistent with UX expectations and doesn't mask unintended message overlap
• Feature flag gate: Ensure MobileLandingPage feature flag scoping is correctly implemented and doesn't affect unintended components

Possibly related PRs

• minor cleanup and bug fixes #439: Modifies ChatPage.razor for async disposal logic; overlaps with this PR's layout/CSS changes to the same file
• Switch to SSR friendly topbar #388: Changes MainLayout.razor layout structure; related to this PR's removal of MainLayout FirstLogin logic and parameter
• Feature/metrics #409: Modifies Login.razor and ExternalLogin.razor for FirstLogin metrics; directly related to this PR's removal of FirstLogin query parameters from the same account flow components

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch bugfix/minor-bugs

---

📜 Recent review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between df6679f and 068d1c6.

📒 Files selected for processing (11)

• src/web/Jordnaer/Components/Account/Pages/ConfirmEmail.razor (1 hunks)
• src/web/Jordnaer/Components/Account/Pages/ExternalLogin.razor (1 hunks)
• src/web/Jordnaer/Components/Account/Pages/Login.razor (1 hunks)
• src/web/Jordnaer/Pages/Chat/ChatPage.razor (1 hunks)
• src/web/Jordnaer/Pages/GroupSearch/GroupSearch.razor (3 hunks)
• src/web/Jordnaer/Pages/Home/DesktopLandingPage.razor (1 hunks)
• src/web/Jordnaer/Pages/Home/MobileLandingPage.razor (1 hunks)
• src/web/Jordnaer/Pages/Posts/Posts.razor (2 hunks)
• src/web/Jordnaer/Pages/Shared/MainLayout.razor (1 hunks)
• src/web/Jordnaer/Pages/UserSearch/UserSearch.razor (3 hunks)
• src/web/Jordnaer/wwwroot/css/chat.css (1 hunks)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}