docs: fix comment inconsistency in getParamsAndCheckValid method#2438
Open
bigmoonbit wants to merge 1704 commits into
Open
docs: fix comment inconsistency in getParamsAndCheckValid method#2438bigmoonbit wants to merge 1704 commits into
bigmoonbit wants to merge 1704 commits into
Conversation
…on (NibiruChain#2074) * fix(evm-keeper): better utilize ERC20 metadata during FunToken creation * chore: changelog
* fix(gas-fees): use effective gas price in RefundGas * Add even more unit clarity for base fee and delete code * fix e2e test and address coderabbitai PR comments * red, green, refactor * red, green, refactor * fix e2e tests
NibiruChain#2088) * refactor(evm): remove outdated comment and improper error message text * chore: changelog
…nt (NibiruChain#2084) * refactor: Collapse e2e directory -> evm-e2e * remove unused ADR directory. Save content elsewhere for later use * feat(evm-forge): Add foundry (forge) template with working commands * chore: changelog
…execution (NibiruChain#2089) * fix(erc20): better handling of gas consumption within erc20 contract execution * chore: changelog update * fix: refactored CallContractWithInput * small PR feedback changes oops oops 2 --------- Co-authored-by: Unique-Divine <realuniquedivine@gmail.com>
…emming from uncommitted, dirty journal entries in the EVM StateDB (NibiruChain#2086)
… 4.0.3 to 4.0.4 in /x/evm/embeds (NibiruChain#2087) * chore(deps): bump secp256k1 from 4.0.3 to 4.0.4 in /x/evm/embeds Bumps [secp256k1](https://github.com/cryptocoinjs/secp256k1-node) from 4.0.3 to 4.0.4. - [Release notes](https://github.com/cryptocoinjs/secp256k1-node/releases) - [Commits](cryptocoinjs/secp256k1-node@v4.0.3...v4.0.4) --- updated-dependencies: - dependency-name: secp256k1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * chore: changelog --------- Signed-off-by: Unique-Divine <realuniquedivine@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Unique Divine <51418232+Unique-Divine@users.noreply.github.com> Co-authored-by: Unique-Divine <realuniquedivine@gmail.com>
…iruChain#2091) * feat: add simple validation for fun token fee in set params * chore: changelog * linting changelog * lint: fix lint issues --------- Co-authored-by: Unique-Divine <realuniquedivine@gmail.com>
…biruChain#2069) * chore(deps): bump bufbuild/buf-setup-action from 1.44.0 to 1.45.0 Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.44.0 to 1.45.0. - [Release notes](https://github.com/bufbuild/buf-setup-action/releases) - [Commits](bufbuild/buf-setup-action@v1.44.0...v1.45.0) --- updated-dependencies: - dependency-name: bufbuild/buf-setup-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Updated changelog - dependabot --------- Signed-off-by: Unique-Divine <Unique-Divine@users.noreply.github.com> Co-authored-by: Unique Divine <51418232+Unique-Divine@users.noreply.github.com>
…iruChain#2070) * chore(deps): bump github.com/btcsuite/btcd from 0.24.0 to 0.24.2 Bumps [github.com/btcsuite/btcd](https://github.com/btcsuite/btcd) from 0.24.0 to 0.24.2. - [Release notes](https://github.com/btcsuite/btcd/releases) - [Changelog](https://github.com/btcsuite/btcd/blob/master/CHANGES) - [Commits](btcsuite/btcd@v0.24.0...v0.24.2) --- updated-dependencies: - dependency-name: github.com/btcsuite/btcd dependency-type: direct:production ... * Updated changelog - dependabot --------- Signed-off-by: Unique-Divine <Unique-Divine@users.noreply.github.com> Co-authored-by: Unique Divine <51418232+Unique-Divine@users.noreply.github.com> Co-authored-by: Unique-Divine <Unique-Divine@users.noreply.github.com>
…le (NibiruChain#2098) * test(evm): statedb tests for race conditions within funtoken precompile * chore: changelog update
…er Nibiru bank keeper that respects the EVM (NibiruChain#2094) * statedb: add cacheing for multistore before precompile runs * messy, working first version that allows for precompile reversion * wip!: Save checkpoint. 1. Created NibiruBankKeeper with safety around NIBI transfers inside of EthereumTx. 2. The "PrecompileCalled" JournalChange now has a propery implementation and a strong test case to show that reverting the precompile calls works as intended. 3. Remove unneeded functions created for testing with low-level struct fields. * chore: changelog * finalize bank keeper changes * revert to previous commit 7f904a0 * fix strange ignored file issue * remove new bank keeper * chore: comments from self-review
* feat: fix transfer for native to erc20 * chore: changelog * feat: check transfer occurred by ensuring new balance is higher than previous one * feat: fix the 0 check * fix: fix error message * feat: move transfer logic to erc20.go * chore: changelog * fix: make the FunToken precompile return the sent amount --------- Co-authored-by: Unique-Divine <realuniquedivine@gmail.com>
* feat: add validation for multi message execution wasm * chore: changelog * merge conflicts + simplify --------- Co-authored-by: Unique-Divine <realuniquedivine@gmail.com>
…al (NibiruChain#2100) * statedb: add cacheing for multistore before precompile runs * messy, working first version that allows for precompile reversion * wip!: Save checkpoint. 1. Created NibiruBankKeeper with safety around NIBI transfers inside of EthereumTx. 2. The "PrecompileCalled" JournalChange now has a propery implementation and a strong test case to show that reverting the precompile calls works as intended. 3. Remove unneeded functions created for testing with low-level struct fields. * chore: changelog * finalize bank keeper changes * revert to previous commit 7f904a0 * fix strange ignored file issue * remove new bank keeper * chore: comments from self-review * refactor: clean up test code * refactor: clean up parse fund args * refactor: clean up common precompile functions * refactor: clean up precompile onrunstart * refactor: clean up precompile onrunstart * refactor: clean up oracle precompile * fix: import * Delete .gitignore * Update CHANGELOG.md * refactor: replace interface{} with any * refactor: add ABI() precompile fn * refactor: replace assertNotReadonlyTx --------- Co-authored-by: Unique-Divine <realuniquedivine@gmail.com>
* fix(evm): tx receipt proper marshalling * test(evm): e2e for tx receipt * chore: justfile cleanup * fix: justfile * fix: minor timeout fix
* feat: enable wasm light clients on IBC (08-wasm) * chore: check if wasm client is already on params * chore(changelog): move to before evm audit --------- Co-authored-by: Kevin Yang <5478483+k-yang@users.noreply.github.com>
…e changes on the StateDB journal (NibiruChain#2095) * statedb: add cacheing for multistore before precompile runs * messy, working first version that allows for precompile reversion * wip!: Save checkpoint. 1. Created NibiruBankKeeper with safety around NIBI transfers inside of EthereumTx. 2. The "PrecompileCalled" JournalChange now has a propery implementation and a strong test case to show that reverting the precompile calls works as intended. 3. Remove unneeded functions created for testing with low-level struct fields. * chore: changelog * finalize bank keeper changes * chore changelog * reset cache * finalize bank keeper changes * revert to previous commit 7f904a0 * fix strange ignored file issue * fix strange ignored file issue * remove new bank keeper * chore: comments from self-review * chore: changelo g * fix(deps): update bank module to remove concrete type assertion on AppModule.RegisterServices This makes it possible to plug in an alternative bankkeeper.Keeper implementation instead of bankkeeper.BaseKeeper. * chore: merge conflicts * revert experiment * finishing touch * fix incorrect arugmetn * feat(evmtest-erc20: Add optional descriptions to the assertions
* feat: add new query for dated prices * feat: use ctx to get timestamp for query * chore: changelog * lint: remove dead code * field rename to include block --------- Co-authored-by: Unique-Divine <realuniquedivine@gmail.com>
…biruChain#2102) * chore(deps): bump bufbuild/buf-setup-action from 1.45.0 to 1.46.0 Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.45.0 to 1.46.0. - [Release notes](https://github.com/bufbuild/buf-setup-action/releases) - [Commits](bufbuild/buf-setup-action@v1.45.0...v1.46.0) --- updated-dependencies: - dependency-name: bufbuild/buf-setup-action dependency-type: direct:production update-type: version-update:semver-minor ... * Updated changelog - dependabot --------- Signed-off-by: Unique-Divine <Unique-Divine@users.noreply.github.com> Co-authored-by: Unique Divine <51418232+Unique-Divine@users.noreply.github.com> Co-authored-by: Unique-Divine <Unique-Divine@users.noreply.github.com>
* test(evm): precompile call with revert * chore: changelog update
…Chain#2093) * feat(evm): gas usage in precompiles: limits, local gas meters * fix: local precompile gas meters * test(precompile): tests for precompile local gas meters * fix: increased funtoken precompile gas limit in favor to heavy user contracts * chore: moved evm grpc calls back to msg_server.go * cleanup * test: added sad test for precompile local gas * fix: duplicate import * chore: cleanup * refactor: clean up imports * fix: bad merge * fix: force switched precompile ctx gas configs * cleanup * fix: gas used discrepancy in estimate gas vs actual execution gas * chore: cleaned up solidity contracts calling bankSend precompile * refactor(gas): simplify estimate gas error handling * refactor(gas): simplify EstimateGasForEvmCallType * fix: comment on HandleOutOfGasPanic * fix: missing gas limit call * test: add WasmGasLimitQuery * refactor: update CallContractWIthInput * refactor(evm): prefer CallContract over CallContractWithInput * refactor: add clarifying context to error messages * fix: eth api test --------- Co-authored-by: Kevin Yang <5478483+k-yang@users.noreply.github.com>
…d "whoAmI" methods (NibiruChain#2107)
…ibiruChain#2108) * fix(evm): removed deprecated root key from eth_getTransactionReceipt * chore: changelog update
…n#2106) * chore: scheduled basic e2e tests for evm testnet endpoint * chore: changelog update * Update and rename e2e-evm-basic-testnet.yml to e2e-evm-cron.yml --------- Co-authored-by: Unique Divine <51418232+Unique-Divine@users.noreply.github.com>
* fix: typo * fix: return to old StateDB pointer in BankKeeper after ApplyEvmMsg * Update CHANGELOG.md
* fix: e2e-evm-cron.yml * Update e2e-evm-cron.yml * chore(e2e-evm-cron.yml): correct the GH secret name to MNEMONIC_TESTNET1_VALIDATOR * chore: changelog update --------- Co-authored-by: Oleg Nikonychev <oleg.nikonychev@gmail.com>
…n#2114) * fix(evm): make conditional balance check free in gas cost * chore: update changelog
…s missing in the bankBalance precompile method (NibiruChain#2116)
commit 08c59b47850586f603ee18061793c3e973b50532
Author: Unique Divine <realuniquedivine@gmail.com>
Date: Thu Oct 23 15:27:38 2025 -0500
merge conf
commit 1dffd7852590c7e0d26129c433569b88f648c106
Merge: 1bfc24d 4dd252f
Author: Unique Divine <realuniquedivine@gmail.com>
Date: Thu Oct 23 15:26:49 2025 -0500
Merge remote-tracking branch 'yin/main' into ud/main-merge-yinwen
commit 4dd252f
Author: yinwenyu6 <yinwenyu6@outlook.com>
Date: Sat Aug 16 20:11:04 2025 +0800
chore: fix function name
Signed-off-by: yinwenyu6 <yinwenyu6@outlook.com>
… "debug_traceBlockByNumber". Fixes [Nibiru#2400 bug](NibiruChain#2400) (NibiruChain#2409) * refactor: use return values without error for function that always succeeds * fix(TraceBlock): use native tracer behavior, not JS parallel tracer; Make test comparisons less brittle * fix(evmstate): trace block gas inconsistency fixed + error on trace tx failure like geth * finish PR for NibiruChain#2400 * tx hash field * fix(vmtracer): include tx hash as one of the fields for trace results * refactor: PR feedback from Gemini-code-assist
…ibiruChain#2390) * chore(deps): bump cipher-base from 1.0.4 to 1.0.6 in /x/evm/embeds Bumps [cipher-base](https://github.com/crypto-browserify/cipher-base) from 1.0.4 to 1.0.6. - [Changelog](https://github.com/browserify/cipher-base/blob/master/CHANGELOG.md) - [Commits](browserify/cipher-base@v1.0.4...v1.0.6) --- updated-dependencies: - dependency-name: cipher-base dependency-version: 1.0.6 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * Updated changelog - dependabot --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Unique-Divine <51418232+Unique-Divine@users.noreply.github.com> Co-authored-by: Unique Divine <realuniquedivine@gmail.com>
* fix(evm-rpc): remove unsafe debug API methods. * refactor: make code organization suggestion from Gemini input
…tions and combine micro-packages (NibiruChain#2413) * fix(evm-rpc): remove unsafe debug API methods. * refactor: make code organization suggestion from Gemini input * refactor(upgrades): simplify upgrade hanlder code to use less abstractions and combine micro-packages * fix tests and add feedback * refactor: last bit of changes from self-review
* wip!: try adding back coverage reports * add trivial go change for CI to start * try newer version, fix license, update install docs * docs(README): face lift with updated docs
…ctors (NibiruChain#2415) * feat: custom ante NewDeductFeeDecorator allowing 0 fee for zero gas actors * chore: changelog * fix: linter * refactor: moved private code to fee.go * impl last PR comment + cleanup --------- Co-authored-by: Unique Divine <realuniquedivine@gmail.com>
… transfer recipient (NibiruChain#2418) * fix(evmstate/test): fix flaky trace tx tests with deterministic ERC20 transfer recipient * changelog
…#2419) * ci: less cache collisions * changelog * better PR template
NibiruChain#2420) * feat: add recursive check for nested authz exec messages and enforce max depth limit * changelog * docs(CHANGELOG): move log entry to correct position --------- Co-authored-by: Unique Divine <51418232+Unique-Divine@users.noreply.github.com>
…Chain#2424) * fix(evm): add panic safety to eth_estimateGas. Fix usage of incorrect SDB context in successive estimation calls. * fix(evm): use geth efficiency improvements and improved BinSearch with lo bias * fix(evm-e2e): newer assertion is more lenient * fix: add suggestion from Cursor bot * fix: bug with ineffectual assignment * ci: add new gen-changelog command to automate its maintenance more * more pr feedback --------- Co-authored-by: Oleg Nikonychev <oleg.nikonychev@gmail.com>
…chain networks, keeping them fast, deterministic, and stable (NibiruChain#2425) * test(oracle): refactor oracle tests to not require running full blockchain networks, keeping them fast, deterministic, and stable * refactor: remove unnecessary msg server functions, * chore: changelog * fix(gen-changelog): improve script robustness * rm temp file * chore: changelog * improvements for oracle
…CI caching (NibiruChain#2431) * chore: changelog * ci(golangci-lint): update linter version to latest (v2.6.1) * ci(golangci-lint): update linter version to latest (v2.6.1); improve CI caching
…consumed on failed EVM tx; nonce increment on the ctx should only happen in DeliverTx and ReCheckTx, not CheckTx (NibiruChain#2434) * fix(evmante): nonce increment on the ctx should only happen in DeliverTx and ReCheckTx, not CheckTx * fix: pull golangci.yml update from other branch * fix: impl panic-safe guard for fixed gas taken by true ante failures in DeliverTx * fix if statement * chore: upgrade handler for v2.9
…cts (NibiruChain#2433) * chore: changelog * sai-trading: add first set of artifacts * sai-trading: toml for build info * sai-trading: start a small program that uses a running nibid process for local testing * chore: add out.txt to gitignore; add justfile comment * sai-trading: project scaffolding with script to deploy all Sai contracts * sai-trading: get a simple test going that checks for the running network in the background * test(ci): need to install bun before running the script * use which instead of command -v * fix array concatenation * make pr title lint more flexible to account for sai-trading and revert changes to app, proto, api * test(.github): fix just install if statement * chore: linter * fix(linter): revert the build tag issue and disable that small piece of govet * Delete TODO_ANALYSIS.md
Signed-off-by: vetclippy <vetclippy@icloud.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request corrects a misleading comment for the getParamsAndCheckValid method. The new comment is a significant improvement in clarity. I have added one suggestion to make the comment even more descriptive by including the function's side effect of sending an error response upon validation failure.
Signed-off-by: bigmoonbit <bigmoonbit@outlook.com>
bigmoonbit
changed the title
Unique-Divine
force-pushed
the
main
branch
4 times, most recently
from
July 2, 2026 11:43
22fb261 to
ac05154
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Abstract
Corrected the misleading comment for the getParamsAndCheckValid method in websockets.go.
The comment previously incorrectly referred to this method as "tcpGetAndSendResponse", which is actually a different method in the same file.
The updated comment now accurately describes the function's purpose: extracting and validating parameters from incoming messages.