Don't affix labels to bills with no actions#1310
Open
yshng wants to merge 2 commits into
Open
Conversation
Corrects #1309 where hidden "None" statuses were appearing in event views. Now we return an empty string and overwrite the core `inferred_status_label` filter with a guard against empty strings. Previously the core filter had @stringfilter and was coercing the None returned by the bill_status_from_last_action filter into "None" before running the rest of the filter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Hidden "None" statuses were appearing in event views. Now we return an empty string and overwrite the core
inferred_status_labelfilter with a guard against empty strings.Previously the councilmatic-core filter was marked
@stringfilterand was thus coercing theNonereturned by thebill_status_from_last_action filter into"None"before running the rest of the filter.Connects #1309