refinements in preparation for LSST#30
Draft
jtmyles wants to merge 28 commits into
Draft
Conversation
…to u/jtmyles/develop
update u/jtmyles/develop with changes implemented in main
…form and `nprocess` for estimate
…form and `nprocess` for estimate
…tive nz function that avoid pandas
Update develop branch with changes to datastore
Merge two user branches into one
…disk in tomobin stage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the following changes:
SOMPZ methodology
overlap_weightto assign galaxies weights in the n(z). This enables weighting galaxies by, for example, shape noise and shear response./stab1515). The truth (equation 4) can be approximated with 'bin conditioning' (equation 5) or the more relaxed criterion of equation 6. Prior to this PR, the code only enabled equation 6. In practice, for a given dataset equation 6 may be an overly permissive approximation of the truth. The SOMPZnz class now allows the user to use the more conservative equation 5.
both of these features were used for the DES analyses, so have been enabled in
rail_sompzfor future applications ofrail_sompzto data and simulations.Code architecture
nprocessfor both the inform and estimate stages, instead of differing termsnprocfor inform andnprocessfor estimaten.