add band checks to knn#17
Open
sschmidt23 wants to merge 6 commits into
Open
Conversation
Collaborator
Author
|
and, my mouse slipped and I created areal PR, oops. |
Collaborator
Author
|
added some linting changes that make the additions looks more substantial than they really are, tests now run ok and should give more informative error messages. Tagging both @aimalz and @hangqianjun for reviewers. |
hangqianjun
approved these changes
Sep 3, 2024
hangqianjun
left a comment
Contributor
There was a problem hiding this comment.
Sorry for getting back to you for so long!! I somehow skipped this PR. It looks good! Some of these tests may be included in a set of more generic column name tests in tables_io.
Collaborator
Author
|
@hangqianjun it looks like you are working on essentially the same checks in tables_io, should we maybe just abandon this PR rather than merging it and just let |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #16 by adding a couple of checks on the bands, ref_band, and mag_limits values. My local pytest is acting up, so I don't know if the tests work or not, I'll create a draft PR to run them here.
Code Quality
#pragma: no cover; in the case of a bugfix, a new test that breaks as a result of the bug has been added