Issue/86/config bug#87
Merged
Merged
Conversation
added 12 commits
January 29, 2026 18:07
It is not added to inform so you need to make the reddening factors outside RAIL to use it at present. This branch will depend on merging the functionality into the main LePHARE code and implementign the reddening calculation in teh c++ lops for speed
This cannot be merged until the corresponding branch is merged on LePHARE. We compute reddening in inform and put it in the model. Alternatively the user can supply a numpy array file containing teh reddening values
change to data store is main change.
Will this work?
Still not sure about insisting on dictionaries being lephare.ZSTEP
Collaborator
Author
|
Before find a longer term solution @johannct it would be good to merge this and release as currently the notebooks are not running following the config updates. |
added 2 commits
May 27, 2026 15:55
We need a longer term solution. a helper function?
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #87 +/- ##
==========================================
- Coverage 93.45% 92.85% -0.60%
==========================================
Files 2 2
Lines 168 168
==========================================
- Hits 157 156 -1
- Misses 11 12 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
johannct
approved these changes
May 27, 2026
johannct
left a comment
johannct
left a comment
Collaborator
There was a problem hiding this comment.
ok for now, but really we need to understand the code....
johannct
requested changes
May 27, 2026
Collaborator
Author
|
Can I merge @johannct ? It is only a couple of minor things but it would be good to merge so the notebooks run. |
johannct
approved these changes
Jun 10, 2026
johannct
left a comment
johannct
left a comment
Collaborator
There was a problem hiding this comment.
Ok let's get that in though it is ugly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem & Solution Description (including issue #)
closes #86
Removes some minor issues relating to updated config values being
lepahre.ZSTEP etc
rather than a lephare_config param which is a dictionary. I presume that RAIL does not want dictionaries as params.
I need to update the notebooks to work with this.
Code Quality
#pragma: no cover; in the case of a bugfix, a new test that breaks as a result of the bug has been added