lephare v1.0.0 merge#83
Merged
Merged
Conversation
added 3 commits
January 29, 2026 18:07
It is not added to inform so you need to make the reddening factors outside RAIL to use it at present. This branch will depend on merging the functionality into the main LePHARE code and implementign the reddening calculation in teh c++ lops for speed
This cannot be merged until the corresponding branch is merged on LePHARE. We compute reddening in inform and put it in the model. Alternatively the user can supply a numpy array file containing teh reddening values
added 3 commits
March 3, 2026 13:02
change to data store is main change.
Collaborator
Author
|
Tests are failing due to not being merged in lepahre yet. We can wait for it to merge or change the workflow to install the lephare branch temporarily. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #83 +/- ##
==========================================
- Coverage 93.45% 92.39% -1.06%
==========================================
Files 2 2
Lines 168 171 +3
==========================================
+ Hits 157 158 +1
- Misses 11 13 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Will this work?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be merged following release of lephare v1.0.0
This is the changes to coincide with the release of lephare v1.0.0. Started as a galametz merge but other issues turned up with the pz challenge.
closes #82
Code Quality
#pragma: no cover; in the case of a bugfix, a new test that breaks as a result of the bug has been added