Skip to content

RAIL Enhancement#81

Merged
jscora merged 10 commits into
LSSTDESC:mainfrom
sidratresearch:sidrat-staging
Feb 18, 2026
Merged

RAIL Enhancement#81
jscora merged 10 commits into
LSSTDESC:mainfrom
sidratresearch:sidrat-staging

Conversation

@taiwithers

@taiwithers taiwithers commented Dec 19, 2025

Copy link
Copy Markdown
Contributor

Problem & Solution Description (including issue #)

This PR updates the code for rail v2.0 by doing the following:

  • adds entrypoint_function variable to all stages to work with new interactive subpackage
  • updates tests to work with new ephemeral DataStores
  • requires lephare>=0.3.0

Code Quality

  • My code follows the code style of this project
  • I have written unit tests or justified all instances of #pragma: no cover; in the case of a bugfix, a new test that breaks as a result of the bug has been added
  • My code contains relevant comments and necessary documentation for future maintainers; the change is reflected in applicable demos/tutorials (with output cleared!) and added/updated docstrings use the NumPy docstring format
  • Any breaking changes, described above, are accompanied by backwards compatibility and deprecation warnings

@taiwithers

Copy link
Copy Markdown
Contributor Author

Tests to be updated (DataStore)

@jscora

jscora commented Dec 19, 2025

Copy link
Copy Markdown
Contributor

Tests have been updated and are now working

@jscora jscora marked this pull request as ready for review December 19, 2025 16:17
@jscora jscora mentioned this pull request Jan 26, 2026
18 tasks
@raphaelshirley

Copy link
Copy Markdown
Collaborator

Hi sorry I missed this from December. I will look at the test failures now.

@raphaelshirley raphaelshirley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we we fix this dependency issue it should pass and be ready to merge

Comment thread pyproject.toml
"pz-rail-base>=1.0.3",
"qp-prob[full]",
]
dependencies = ["lephare>=0.3.0", "pz-rail-base>=2.0.0-dev", "qp-prob[full]"]

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be the line causing:

ERROR: No matching distribution found for pz-rail-base>=2.0.0-dev

Can we change it to 2.0.0 for instance?

@raphaelshirley raphaelshirley Jan 27, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is 1.1.4 as per sklearn ok?

https://github.com/LSSTDESC/rail_sklearn/blob/b34e2ec4625e9fa12cfe2ef80c3d8aeebe84e9a2/pyproject.toml#L19

The whole point of the PR is to update to 2.0.0. Are we waiting for it to go live. Or can we simply remove the -dev part?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused because it seems to be passing for rail_flexzboost

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, sorry I think that is a mistake, I'll change it to pz-rail-base>=2.0.0. But even with the correction it won't work since we don't have rail 2.0 yet unfortunately! But we've run the tests on our system and they are working fine

@raphaelshirley raphaelshirley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to check the tests run here before merging but happy to merge given they passed locally.

@jscora jscora merged commit c88c610 into LSSTDESC:main Feb 18, 2026
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants