RAIL Enhancement#81
Conversation
|
Tests to be updated (DataStore) |
…tion names are correct, cleaned up tests
|
Tests have been updated and are now working |
|
Hi sorry I missed this from December. I will look at the test failures now. |
raphaelshirley
left a comment
There was a problem hiding this comment.
I think we we fix this dependency issue it should pass and be ready to merge
| "pz-rail-base>=1.0.3", | ||
| "qp-prob[full]", | ||
| ] | ||
| dependencies = ["lephare>=0.3.0", "pz-rail-base>=2.0.0-dev", "qp-prob[full]"] |
There was a problem hiding this comment.
This seems to be the line causing:
ERROR: No matching distribution found for pz-rail-base>=2.0.0-dev
Can we change it to 2.0.0 for instance?
There was a problem hiding this comment.
Is 1.1.4 as per sklearn ok?
The whole point of the PR is to update to 2.0.0. Are we waiting for it to go live. Or can we simply remove the -dev part?
There was a problem hiding this comment.
I'm confused because it seems to be passing for rail_flexzboost
There was a problem hiding this comment.
Hi, sorry I think that is a mistake, I'll change it to pz-rail-base>=2.0.0. But even with the correction it won't work since we don't have rail 2.0 yet unfortunately! But we've run the tests on our system and they are working fine
raphaelshirley
left a comment
There was a problem hiding this comment.
It would be good to check the tests run here before merging but happy to merge given they passed locally.
Problem & Solution Description (including issue #)
This PR updates the code for rail v2.0 by doing the following:
Code Quality
#pragma: no cover; in the case of a bugfix, a new test that breaks as a result of the bug has been added