Skip to content

Submission: rail_knn_4tasks (RAIL KNN, all 4 task sets, draft)#30

Merged
eacharles merged 2 commits into
LSSTDESC:mainfrom
Lhior:rail_knn_4tasks
Jun 22, 2026
Merged

Submission: rail_knn_4tasks (RAIL KNN, all 4 task sets, draft)#30
eacharles merged 2 commits into
LSSTDESC:mainfrom
Lhior:rail_knn_4tasks

Conversation

@Lhior

@Lhior Lhior commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Summary

  • New submission rail_knn_4tasks covering task sets 1–4 with RAIL KNearNeighInformer / KNearNeighEstimator.
  • Structure follows PR #28 (BPZ all-4-task-set template).
  • KNN algorithm from PR #8; NaN redshift cleaning on training data for task sets 3/4 (PR #6).
  • Uses catalog_utils.apply("cardinal_roman_rubin") for LSST + Roman bands.
  • Precomputed models + qp estimates: pzdc-rail-knn-4tasks-v1.
  • Uses public_test.tgz until data moves to public.tgz.

Test plan

  • pytest tests/test_rail_knn_4tasks.py passes locally (all 4 task sets, ~10 min)
  • CI workflow submit_rail_knn_4tasks green

Made with Cursor

Lhior and others added 2 commits June 12, 2026 13:51
Follows PR LSSTDESC#28 structure with KNN from PR LSSTDESC#8 and NaN redshift cleaning
for task sets 3/4. Precomputed tarball on fork release pzdc-rail-knn-4tasks-v1.

Co-authored-by: Cursor <cursoragent@cursor.com>
Leave global conftest unchanged from upstream main; avoid public_test.tgz
which times out from GitHub Actions runners.

Co-authored-by: Cursor <cursoragent@cursor.com>
@eacharles eacharles marked this pull request as ready for review June 22, 2026 22:49
@eacharles eacharles self-requested a review June 22, 2026 22:49

@eacharles eacharles left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@eacharles eacharles merged commit 7bec23e into LSSTDESC:main Jun 22, 2026
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants