Fixes

Author: JobDoesburg

landolfio/inventory_frontend/templates/detail.html

@@ -457,7 +457,7 @@ <h5>{% translate "No active agreements" %}</h5>
         <div class="tab-pane fade purchase-price" id="history">
             <div class="row">
                 <div class="col-12">
-                    {% if asset.journal_document_lines.exists %}
+                    {% if journal_history %}
                         <div class="table-responsive">
                             <table class="table table-hover">
                                 <thead>
@@ -469,7 +469,7 @@ <h5>{% translate "No active agreements" %}</h5>
                                     </tr>
                                 </thead>
                                 <tbody>
-                                    {% for line in asset.journal_document_line_assets.all %}
+                                    {% for line in journal_history %}
                                         <tr>
                                             <td>{{ line.document_line.document.date|date:"d-m-Y" }}</td>
                                             <td>{{ line.document_line.description }}</td>

landolfio/inventory_frontend/views.py

@@ -1,15 +1,14 @@
 from django.contrib import messages
 from django.shortcuts import redirect
-from django.views.generic import ListView, DetailView, CreateView, UpdateView
-from django.contrib.auth.mixins import LoginRequiredMixin
+from django.views.generic import ListView, DetailView, CreateView
 from django.db.models import Q
 from django.http import JsonResponse
-from django.urls import reverse_lazy
 from django_drf_filepond.api import store_upload
 from django_drf_filepond.models import TemporaryUpload
 from django.views import View
 
 from inventory.models.asset import Asset, AssetStates
+from inventory.models.asset_on_document_line import AssetOnJournalDocumentLine
 from inventory.models.attachment import Attachment, attachments_directory_path
 from inventory.models.category import Category
 from inventory.models.collection import Collection
@@ -252,6 +251,12 @@ def get_context_data(self, **kwargs):
         ]
         context["locations"] = Location.objects.all().order_by("order", "name")
 
+        context["journal_history"] = (
+            AssetOnJournalDocumentLine.objects.filter(asset=asset)
+            .select_related("document_line__document", "document_line__ledger_account")
+            .order_by("-document_line__document__date")
+        )
+
         return context
 
     def post(self, request, *args, **kwargs):

landolfio/ninox_import/ninox_sync.py

@@ -194,9 +194,9 @@ def get(self, url, stream=False):
             response.raise_for_status()
             self._logger.info(f"Got response: {response}")
         except HTTPError as http_err:
-            print(f"HTTP error occurred: {http_err}")
+            self._logger.error(f"HTTP error occurred: {http_err}")
         except Exception as err:
-            print(f"Other error occurred: {err}")
+            self._logger.error(f"Other error occurred: {err}")
         else:
             if stream:
                 return response