Skip to content

Fix: exports.module.default does not exist#20

Open
tstone wants to merge 3 commits into
JS-DevTools:masterfrom
tstone:module-default-fix
Open

Fix: exports.module.default does not exist#20
tstone wants to merge 3 commits into
JS-DevTools:masterfrom
tstone:module-default-fix

Conversation

@tstone

@tstone tstone commented Jun 16, 2023

Copy link
Copy Markdown

This PR fixes a tiny bug where module.exports exists but module.exports.default does not. An additional check is added to the conditional before proceeding.

mquan added a commit to mquan/api2ai that referenced this pull request Jul 21, 2023
Details in JS-DevTools/ono#19, It's fixed in JS-DevTools/ono#20
This package is not maintained but it's depended on by swagger-parser
@Malcolm-Q

Copy link
Copy Markdown

Nearly a year later. Any reason this hasn't been merged?

@UnexpectedLobster

Copy link
Copy Markdown

This needs to be merged as any rollup / vitejs build are broken without it

@ValeryG

ValeryG commented May 14, 2024

Copy link
Copy Markdown

please merge this! :)

@feloy

feloy commented Aug 22, 2024

Copy link
Copy Markdown

Hi @JamesMessinger, any chance to have this PR merged? It would unblock all projects using roolup/vitejs builders

@dyram-ivoyant-eng

Copy link
Copy Markdown

Please merge this PR 🥺🙏

@mlh86

mlh86 commented Jan 4, 2025

Copy link
Copy Markdown

Can this PR please be merged? The bug is breaking my import of the 'next-swagger-doc' package. I've confirmed that the one-line change fixes the import issue.

@tstone

tstone commented Mar 6, 2025

Copy link
Copy Markdown
Author

@JamesMessinger ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants