COAR DOI checks#12538
Open
qqmyers wants to merge 2 commits into
Open
Conversation
pdurbin
moved this from Ready for Triage
to Ready for Review ⏩
in IQSS Dataverse Project
pdurbin
added
Size: 3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: The COAR Notify Relationship Announcement processor can call DataCite and use Datacite metadata to find the title and type of a related resource. This PR avoids unnecessary calls if the PID is not a DOI.
Which issue(s) this PR closes:
Special notes for your reviewer: Also tweaked the docs to repeat the recommendation to not use allowed-hosts=* in production in the config guide (it was already noted in https://guides.dataverse.org/en/latest/api/linkeddatanotification.html#linked-data-notification-api ).
Suggestions on how to test this: Unit test included. Nominally could test with a DSpace instance or manually generated messages as well if you can detect the outgoing call being suppressed.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: