PrePublish disclaimer for submit for review

[stevenwinship]

What this PR does / why we need it: Need a message explains Submit for Review so users are aware of the workflow.

Which issue(s) this PR closes:#12325

• Closes Submit for review: When a user selects this option, a message should indicate the dataset will be reviewed and published #12325

Special notes for your reviewer:

Suggestions on how to test this: Sample settings values
curl -sS -X PUT -d 'I agree to the following:<br/>1. My submission has been fully anonymized (required for all human subjects'\'' datasets).<br/>2. My submission does not violate any known copyright laws.<br/>3. I understand that I am liable for any and all violations of the Harvard Repository <a href=https://support.dataverse.harvard.edu/harvard-dataverse-general-terms-use>Terms of Use.</a>' http://localhost:8080/api/admin/settings/:SubmitForReviewDatasetDisclaimerText

curl -sS -X PUT -d 'This dataset is being submitted for review and publishing.<br/><span style="color: red;">If PUBLISHING is not your intended workflow</span>, do not submit this for review and contact <a href="https://support.dataverse.harvard.edu/"> support.</a>' http://localhost:8080/api/admin/settings/:DatasetSubmitForReviewPopupCustomText

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?: included

Additional documentation:

[coveralls]

coverage: 24.956% (-0.002%) from 24.958% — 12325-submit-for-review-message into develop

[rtreacy]

Looks good

[landreev]

Everything is working as advertised.
With the same exact settings as specified in "how to test" verbatim, the popup looks 1:1 as in the screenshot.
@stevenwinship
Just curious, where did the words "pre-publish" (as in, PrePublishDatasetDisclaimerText) come from? - instead of just referring to it as SubmitForRevieweverywhere. Is that how curation prefer to talk about this process?

"Pre publish" has been used in the context of workflows. But it means something else there.
Ready to merge generally.

[landreev]

Just curious, where did the words "pre-publish" ... come from

@stevenwinship n/m, I see it in the discussion in the issue (#12325).

[landreev]

... although I am still a little confused. Will ask a quick question in the issue.

Just curious, where did the words "pre-publish" ... come from

@stevenwinship n/m, I see it in the discussion in the issue (#12325).

[landreev]

It looks great, IMO and is still working as advertised.
I pinged @scolapasta and @pdurbin on slack just to give them an extra chance to stop me from merging the pr. Otherwise will merge shortly.

[github-actions]

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:12325-submit-for-review-message

ghcr.io/gdcc/configbaker:12325-submit-for-review-message

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

[landreev]

Heard back, merging.