Skip to content

Improvements in handles support #12366

Merged
stevenwinship merged 6 commits into
developfrom
12174-file-level-handles
May 4, 2026
Merged

Improvements in handles support #12366
stevenwinship merged 6 commits into
developfrom
12174-file-level-handles

Conversation

@landreev

@landreev landreev commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Unplanned, and somewhat low effort PR in response to a problem report from a community member. Once I started looking into it, I realized the fix would be trivial, and that a much older issue opened by the same user could be fixed similarly for cheap.

See the release note for the summary of the fixes.

Which issue(s) this PR closes:

Special notes for your reviewer:

I tried to rebase the branch and squash the 3 commits into one. But for whatever reason the first 3 commits are still showing individually. 🤷

Suggestions on how to test this:

See the release note for the summary of the fixes.

The dev. team maintains a fully-functional handles instance with its own name space (hdl:20.500.12050) which should be used for testing anything handles-related.

This can be done on:

  1. dataverse-internal: we have our normal DataCite test setup configured as the default pid provider there. But it has an additional pid provider testhandles configured that uses the name space above.
  2. Any dev. environment can be configured to use the name space and the handlenet server above. Follow the instructions in the new "Additional Services" tab of the shared dev resources document: https://docs.google.com/document/d/1jDle38XL4ReL8m-c0yGHXs2-jIlqNKFaUa-Qyf9I1VI/edit?pli=1&tab=t.5uif8rchd0ur

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@github-actions github-actions Bot added Feature: DOI & Handle FY26 Sprint 22 FY26 Sprint 22 (2026-04-22 - 2026-05-06) Original size: 10 Type: Bug a defect Type: Suggestion an idea User Role: Depositor Creates datasets, uploads data, etc. labels Apr 28, 2026
@coveralls

coveralls commented Apr 28, 2026

Copy link
Copy Markdown

Coverage Status

coverage: 24.959% (-0.004%) from 24.963% — 12174-file-level-handles into develop

@github-actions

This comment has been minimized.

@landreev landreev changed the title 12174 file level handles Improvements in handles support Apr 29, 2026
@landreev
landreev marked this pull request as ready for review April 29, 2026 17:20
@landreev landreev self-assigned this Apr 29, 2026
@landreev landreev moved this to Ready for Review ⏩ in IQSS Dataverse Project Apr 29, 2026
@landreev landreev removed their assignment Apr 29, 2026
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

Copy link
Copy Markdown

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:12174-file-level-handles
ghcr.io/gdcc/configbaker:12174-file-level-handles

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

@pdurbin pdurbin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test this but the change makes sense. Approved!

datasetUrl.getBytes(),
HandleValue.TTL_TYPE_RELATIVE, 86400,
timestamp, null, true, true, true, false)};
timestamp, null, true, true, false, false)};

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine but I'm just leaving a comment so we can easily see that "publicRead" is what's being changed:

    this.timestamp = timestamp;
    this.references = references;
    this.adminRead = adminRead;
    this.adminWrite = adminWrite;
    this.publicRead = publicRead;
    this.publicWrite = publicWrite;

@github-project-automation github-project-automation Bot moved this from Ready for Review ⏩ to Ready for QA ⏩ in IQSS Dataverse Project Apr 29, 2026
@stevenwinship stevenwinship moved this from Ready for QA ⏩ to QA ✅ in IQSS Dataverse Project May 4, 2026
@stevenwinship stevenwinship self-assigned this May 4, 2026
@stevenwinship
stevenwinship merged commit 8a603e2 into develop May 4, 2026
20 checks passed
@github-project-automation github-project-automation Bot moved this from QA ✅ to Merged 🚀 in IQSS Dataverse Project May 4, 2026
@stevenwinship stevenwinship removed their assignment May 4, 2026
@pdurbin pdurbin added this to the 6.11 milestone May 5, 2026
@jp-tosca jp-tosca moved this from Merged 🚀 to Done 🧹 in IQSS Dataverse Project May 5, 2026
@landreev

landreev commented May 5, 2026

Copy link
Copy Markdown
Contributor Author

@stevenwinship Thanks for testing the new "dev. handlenet" instruction in the process btw. I'm hoping it will be useful going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature: DOI & Handle FY26 Sprint 22 FY26 Sprint 22 (2026-04-22 - 2026-05-06) Original size: 10 Type: Bug a defect Type: Suggestion an idea User Role: Depositor Creates datasets, uploads data, etc.

Projects

Status: Done 🧹

5 participants