Skip to content

Add dataset type ID to JSON output in JsonPrinter#12348

Merged
landreev merged 1 commit into
developfrom
add_id_to_types
Apr 22, 2026
Merged

Add dataset type ID to JSON output in JsonPrinter#12348
landreev merged 1 commit into
developfrom
add_id_to_types

Conversation

@jp-tosca

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

The Id on the type is required for mapping on JS Dataverse

@jp-tosca jp-tosca moved this to Ready for Review ⏩ in IQSS Dataverse Project Apr 21, 2026
@jp-tosca jp-tosca added Feature: API Size: 3 A percentage of a sprint. 2.1 hours. SPA These changes are required for the Dataverse SPA labels Apr 21, 2026
@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 24.885% (+0.004%) from 24.881% — add_id_to_types into develop

@landreev landreev self-assigned this Apr 21, 2026
@github-actions

Copy link
Copy Markdown

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:add-id-to-types
ghcr.io/gdcc/configbaker:add-id-to-types

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

@landreev landreev moved this from Ready for Review ⏩ to In Review 🔎 in IQSS Dataverse Project Apr 21, 2026
@landreev
landreev self-requested a review April 21, 2026 20:38

@landreev landreev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@github-project-automation github-project-automation Bot moved this from In Review 🔎 to Ready for QA ⏩ in IQSS Dataverse Project Apr 22, 2026
@landreev
landreev merged commit 823c754 into develop Apr 22, 2026
27 checks passed
@github-project-automation github-project-automation Bot moved this from Ready for QA ⏩ to Merged 🚀 in IQSS Dataverse Project Apr 22, 2026
@landreev
landreev deleted the add_id_to_types branch April 22, 2026 14:08
@jp-tosca jp-tosca moved this from Merged 🚀 to Done 🧹 in IQSS Dataverse Project Apr 22, 2026
@pdurbin pdurbin added this to the 6.11 milestone Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature: API Size: 3 A percentage of a sprint. 2.1 hours. SPA These changes are required for the Dataverse SPA

Projects

Status: Done 🧹

Development

Successfully merging this pull request may close these issues.

4 participants