-
Notifications
You must be signed in to change notification settings - Fork 557
Added support for HTML in JSF UI for file description #12318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
pdurbin
merged 6 commits into
develop
from
11397-support-html-in-file-level-description
Jul 13, 2026
Merged
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
5a7c14b
Added Suport for HTML in JSF UI for file description
stevenwinship 4619c0b
change markup Checking from advanced to basic
stevenwinship 2183134
add sanitizeBasicHTML to file-info-fragment
stevenwinship a08540c
added html supported description to search page
stevenwinship c1e3bca
handle html in search-include-fragment
stevenwinship 8b92009
fix to strip link off description on search cards
stevenwinship File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
2 changes: 2 additions & 0 deletions
2
doc/release-notes/11397-support-html-in-file-level-description.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| ## Feature Request | ||
| File metadata description will now support html in JSF UI. Is already supported in SPA. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,12 @@ | ||
| <ui:composition xmlns="http://www.w3.org/1999/xhtml" | ||
| xmlns:h="http://java.sun.com/jsf/html" | ||
| xmlns:f="http://java.sun.com/jsf/core" | ||
| xmlns:ui="http://java.sun.com/jsf/facelets" | ||
| xmlns:c="http://java.sun.com/jsp/jstl/core" | ||
| xmlns:p="http://primefaces.org/ui" | ||
| xmlns:o="http://omnifaces.org/ui" | ||
| xmlns:of="http://omnifaces.org/functions" | ||
| xmlns:jsf="http://xmlns.jcp.org/jsf"> | ||
| xmlns:h="http://java.sun.com/jsf/html" | ||
| xmlns:f="http://java.sun.com/jsf/core" | ||
| xmlns:ui="http://java.sun.com/jsf/facelets" | ||
| xmlns:c="http://java.sun.com/jsp/jstl/core" | ||
| xmlns:p="http://primefaces.org/ui" | ||
| xmlns:o="http://omnifaces.org/ui" | ||
| xmlns:of="http://omnifaces.org/functions" | ||
| xmlns:jsf="http://xmlns.jcp.org/jsf" xmlns:Strings="http://omnifaces.org/functions"> | ||
|
stevenwinship marked this conversation as resolved.
Outdated
|
||
|
|
||
| <c:set var="page" value="/dataverse/#{DataversePage.dataverse.alias}"/> | ||
| <c:set var="cvocConf" value="#{settingsWrapper.getCVocConf(true)}"/> | ||
|
|
@@ -539,7 +539,7 @@ | |
|
|
||
| <hr style="margin:.5em;border:0;"/> | ||
|
|
||
| <h:outputText value="#{Strings:abbreviate(result.descriptionNoSnippet, descriptionAbbreviationThreshold)}" rendered="#{result.descriptionSnippets.size() eq 0}"/> | ||
| <h:outputText value="#{Strings:abbreviate(MarkupChecker:sanitizeBasicHTML(result.descriptionNoSnippet), descriptionAbbreviationThreshold)}" escape="false" rendered="#{result.descriptionSnippets.size() eq 0}"/> | ||
|
|
||
| <ui:repeat value="#{result.descriptionSnippets}" var="snippet" varStatus="varStatus" | ||
| rendered="#{result.descriptionSnippets.size() gt 0}"> | ||
|
|
@@ -607,7 +607,7 @@ | |
| <h:outputText value="#{result.citationHtml != null ? result.citationHtml : result.citation}" escape="false"/> | ||
| </div> | ||
|
|
||
| <h:outputText value="#{Strings:abbreviate(result.descriptionNoSnippet, descriptionAbbreviationThreshold)}" rendered="#{result.descriptionSnippets.size() eq 0}"/> | ||
| <h:outputText value="#{Strings:abbreviate(MarkupChecker:sanitizeBasicHTML(result.descriptionNoSnippet), descriptionAbbreviationThreshold)}" escape="false" rendered="#{result.descriptionSnippets.size() eq 0}"/> | ||
|
|
||
| <ui:repeat value="#{result.descriptionSnippets}" var="snippet" varStatus="varStatus" | ||
| rendered="#{result.descriptionSnippets.size() gt 0}"> | ||
|
|
@@ -721,7 +721,7 @@ | |
| </ui:repeat> | ||
| </div> | ||
|
|
||
| <h:outputText value="#{Strings:abbreviate(result.descriptionNoSnippet, descriptionAbbreviationThreshold)}" rendered="#{result.descriptionSnippets.size() eq 0}"/> | ||
| <h:outputText value="#{Strings:abbreviate(MarkupChecker:sanitizeBasicHTML(result.descriptionNoSnippet), descriptionAbbreviationThreshold)}" escape="false" rendered="#{result.descriptionSnippets.size() eq 0}"/> | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For consistency, we want the search card to not have a clickable link, just like the collection card and dataset card. |
||
|
|
||
| <ui:repeat value="#{result.descriptionSnippets}" var="snippet" varStatus="varStatus" | ||
| rendered="#{result.descriptionSnippets.size() gt 0}"> | ||
|
stevenwinship marked this conversation as resolved.
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.