Skip to content

Add usage and response counts to get guestbooks list#12269

Merged
ChengShi-1 merged 3 commits into
developfrom
12260-get-guestbook-with-usage-and-response-counts
May 11, 2026
Merged

Add usage and response counts to get guestbooks list#12269
ChengShi-1 merged 3 commits into
developfrom
12260-get-guestbook-with-usage-and-response-counts

Conversation

@stevenwinship

@stevenwinship stevenwinship commented Mar 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:Currently, the GET Guestbook API returns metadata about guestbooks (e.g., name, required fields, custom questions), but it does not include usage and responses, needed for Manage Guestbooks table

Which issue(s) this PR closes:#12260

Special notes for your reviewer:

Suggestions on how to test this:

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?: Included

Additional documentation:

@stevenwinship stevenwinship self-assigned this Mar 31, 2026
@github-actions github-actions Bot added FY26 Sprint 20 FY26 Sprint 20 (2026-03-26 - 2026-04-08) Size: 10 A percentage of a sprint. 7 hours. SPA These changes are required for the Dataverse SPA labels Mar 31, 2026
@stevenwinship stevenwinship moved this to In Progress 💻 in IQSS Dataverse Project Mar 31, 2026
@github-actions github-actions Bot added the Type: Feature a feature request label Mar 31, 2026
@stevenwinship stevenwinship changed the title Add usage and response counts to get guestbook Add usage and response counts to get guestbooks list Mar 31, 2026
@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
@stevenwinship stevenwinship moved this from In Progress 💻 to Ready for Review ⏩ in IQSS Dataverse Project Mar 31, 2026
@stevenwinship stevenwinship removed their assignment Mar 31, 2026
scolapasta
scolapasta previously requested changes Apr 1, 2026
View reviewed changes

@scolapasta scolapasta left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment about the default for discussion.

Also branch is out of date.

Comment thread src/main/java/edu/harvard/iq/dataverse/api/Guestbooks.java Outdated
@scolapasta scolapasta moved this from Ready for Review ⏩ to In Review 🔎 in IQSS Dataverse Project Apr 1, 2026
@stevenwinship stevenwinship removed their assignment Apr 2, 2026
@stevenwinship
stevenwinship force-pushed the 12260-get-guestbook-with-usage-and-response-counts branch from 13fad7f to b567bef Compare April 2, 2026 14:22
@github-actions

This comment has been minimized.

Sign in to view
@coveralls

coveralls commented Apr 2, 2026 •
edited
Loading

Copy link
Copy Markdown

Coverage Status

coverage: 24.961% (-0.002%) from 24.963% — 12260-get-guestbook-with-usage-and-response-counts into develop

@github-actions

This comment has been minimized.

Sign in to view
@ChengShi-1 ChengShi-1 mentioned this pull request Apr 8, 2026
Closed
@cmbz cmbz added the FY26 Sprint 21 FY26 Sprint 21 (2026-04-08 - 2026-04-22) label Apr 8, 2026
@stevenwinship
stevenwinship force-pushed the 12260-get-guestbook-with-usage-and-response-counts branch from b567bef to 9f8fe52 Compare April 9, 2026 16:10
@github-actions

This comment has been minimized.

Sign in to view
@stevenwinship
stevenwinship force-pushed the 12260-get-guestbook-with-usage-and-response-counts branch from 9f8fe52 to 7a4780a Compare April 14, 2026 14:46
@github-actions

This comment has been minimized.

Sign in to view
@stevenwinship
stevenwinship force-pushed the 12260-get-guestbook-with-usage-and-response-counts branch from 7a4780a to 37ea479 Compare April 15, 2026 18:42
@github-actions

This comment has been minimized.

Sign in to view
@stevenwinship
stevenwinship force-pushed the 12260-get-guestbook-with-usage-and-response-counts branch from 4e19e71 to cbf868b Compare April 21, 2026 15:18
@github-actions

This comment has been minimized.

Sign in to view
@stevenwinship
stevenwinship force-pushed the 12260-get-guestbook-with-usage-and-response-counts branch from cbf868b to 6204168 Compare April 22, 2026 18:59
@github-actions

This comment has been minimized.

Sign in to view
@cmbz cmbz added the FY26 Sprint 22 FY26 Sprint 22 (2026-04-22 - 2026-05-06) label Apr 22, 2026
@stevenwinship
stevenwinship force-pushed the 12260-get-guestbook-with-usage-and-response-counts branch from 6204168 to 185dc32 Compare April 23, 2026 15:08
@github-actions

This comment has been minimized.

Sign in to view
@stevenwinship
stevenwinship force-pushed the 12260-get-guestbook-with-usage-and-response-counts branch from 185dc32 to 75a0f44 Compare April 27, 2026 13:07
@github-actions

This comment has been minimized.

Sign in to view
@stevenwinship
stevenwinship force-pushed the 12260-get-guestbook-with-usage-and-response-counts branch from 75a0f44 to f3bfe55 Compare April 28, 2026 21:03
@github-actions

github-actions Bot commented Apr 28, 2026

Copy link
Copy Markdown

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:12260-get-guestbook-with-usage-and-response-counts

ghcr.io/gdcc/configbaker:12260-get-guestbook-with-usage-and-response-counts

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

@github-project-automation github-project-automation Bot moved this from In Review 🔎 to Ready for QA ⏩ in IQSS Dataverse Project Apr 30, 2026
@scolapasta scolapasta removed their assignment Apr 30, 2026
@ChengShi-1 ChengShi-1 mentioned this pull request May 6, 2026
Closed
2 tasks
@ChengShi-1 ChengShi-1 moved this from Ready for QA ⏩ to QA ✅ in IQSS Dataverse Project May 6, 2026
@ChengShi-1 ChengShi-1 self-assigned this May 6, 2026
@ChengShi-1 ChengShi-1 mentioned this pull request May 6, 2026
Closed
@cmbz cmbz added the FY26 Sprint 23 FY26 Sprint 23 (2026-05-06 - 2026-05-20) label May 6, 2026
ChengShi-1
ChengShi-1 approved these changes May 11, 2026
View reviewed changes

@ChengShi-1 ChengShi-1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good with api tests

@github-project-automation github-project-automation Bot moved this from QA ✅ to Ready for QA ⏩ in IQSS Dataverse Project May 11, 2026
@ChengShi-1
ChengShi-1 merged commit 1b4a17a into develop May 11, 2026
21 checks passed
@github-project-automation github-project-automation Bot moved this from Ready for QA ⏩ to Merged 🚀 in IQSS Dataverse Project May 11, 2026
@pdurbin pdurbin added this to the 6.11 milestone May 12, 2026
@jp-tosca jp-tosca moved this from Merged 🚀 to Done 🧹 in IQSS Dataverse Project May 12, 2026
@stevenwinship
stevenwinship deleted the 12260-get-guestbook-with-usage-and-response-counts branch May 12, 2026 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChengShi-1 ChengShi-1 ChengShi-1 approved these changes
+1 more reviewer
@scolapasta scolapasta scolapasta approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

FY26 Sprint 20 FY26 Sprint 20 (2026-03-26 - 2026-04-08) FY26 Sprint 21 FY26 Sprint 21 (2026-04-08 - 2026-04-22) FY26 Sprint 22 FY26 Sprint 22 (2026-04-22 - 2026-05-06) FY26 Sprint 23 FY26 Sprint 23 (2026-05-06 - 2026-05-20) Size: 10 A percentage of a sprint. 7 hours. SPA These changes are required for the Dataverse SPA Type: Feature a feature request

Projects

IQSS Dataverse Project
Status: Done 🧹

Milestone

6.11

Development

Successfully merging this pull request may close these issues.

API: Enhance GET Guestbooks with usage count and response count fields

7 participants

@stevenwinship @coveralls @scolapasta @ChengShi-1 @pdurbin @cmbz @jp-tosca