fix(cron): reject invalid schedule parameters at creation time#4285
Open
yorkhellen wants to merge 1 commit into
Open
fix(cron): reject invalid schedule parameters at creation time#4285yorkhellen wants to merge 1 commit into
yorkhellen wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_validate_schedule_for_addto validate all schedule kinds upfront: reject invalid/empty cron expressions (croniter.is_valid), non-positiveevery_ms, missingat_ms, andtzused with non-cron schedules
ValueErrorinCronTool._add_joband return a user-facing error string instead of letting the exception propagate into the tool execution flow"not a cron"would silently create a job withnext_run_at_ms=Nonethat would never execute — the user/agent would see "Created job" with no indication of failureTest plan
every_ms <= 0, negativeevery_ms, missingat_ms,tzwithevery,tzwithatError:, empty cron expr returnsError: