Skip to content

feat: Replace native alert with custom ConfirmationModal#116

Merged
Gyanthakur merged 1 commit into
Gyanthakur:mainfrom
Shanidhya01:feat/custom-confirmation-modal
Oct 12, 2025
Merged

feat: Replace native alert with custom ConfirmationModal#116
Gyanthakur merged 1 commit into
Gyanthakur:mainfrom
Shanidhya01:feat/custom-confirmation-modal

Conversation

@Shanidhya01

Copy link
Copy Markdown
Contributor
  • Create reusable ConfirmationModal component with accessibility features
  • Add smooth fade-in/out animations and backdrop blur
  • Support multiple variants (warning, danger, info)
  • Replace window.confirm() in Analytics page with custom modal
  • Add proper state management and user feedback

Features:

  • Keyboard navigation (ESC to close)
  • Click outside to dismiss
  • ARIA labels and screen reader support
  • Responsive design with Tailwind CSS
  • Customizable title, message, and button text

Fixes the outdated browser alert UX issue in Analytics page.

📝 Description

Create a reusable ConfirmationModal component with accessibility, smooth animations, and proper UX to replace all native window.confirm() usages across the app (starting with the Analytics page).

Fixes #110


🔍 Type of Change

Please delete options that are not relevant.

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • [✅ ] 🚀 New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ✅] 🧹 Code cleanup or refactor

✅ Checklist

  • [ ✅] My code follows the project’s coding style and guidelines.
  • [✅ ] I have performed a self-review of my code.
  • [✅ ] I have commented my code where necessary.
  • [✅ ] I have added tests that prove my fix is effective or that my feature works.
  • [✅ ] New and existing tests pass locally with my changes.
  • [ ✅] I have updated the documentation if required.

📸 Screenshots (if applicable)

Before

Screen.Recording.2025-10-12.125834.mp4

After

Screen.Recording.2025-10-12.125725.mp4

- Create reusable ConfirmationModal component with accessibility features
- Add smooth fade-in/out animations and backdrop blur
- Support multiple variants (warning, danger, info)
- Replace window.confirm() in Analytics page with custom modal
- Add proper state management and user feedback
- Include comprehensive documentation

Features:
- Keyboard navigation (ESC to close)
- Click outside to dismiss
- ARIA labels and screen reader support
- Responsive design with Tailwind CSS
- Customizable title, message, and button text

Fixes the outdated browser alert UX issue in Analytics page.
@vercel

vercel Bot commented Oct 12, 2025

Copy link
Copy Markdown

@Shanidhya01 is attempting to deploy a commit to the gyanthakur's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @Shanidhya01! Thanks for creating the pull request.
Soon the maintainers/owner will review it and provide you with feedback/suggestions.
Make sure to star this awesome repository and follow the account!

@vercel

vercel Bot commented Oct 12, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
component-library Ready Ready Preview Comment Oct 12, 2025 5:13pm

@Gyanthakur Gyanthakur merged commit 8e54c58 into Gyanthakur:main Oct 12, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue Title: Replace browser alert with custom popup for “Reset Data” action

2 participants