Bookkeeping - merge recent changes from release/4.x#506
Merged
Conversation
…and >1D input with all but one row/column fully masked (ie. only 1 model to fit).
…ded behaviour for fully-masked data.
# Conflicts: # gempy/library/fitting.py
…e npix or dw, and remove debugging print functions
…pe to the SQ library.
…* rectification model
This reverts commit 6f886c0.
…her than crash later on an IndexError. Also provide the user a possible solution.
…igher GNIRS XD order because the sky lines are a bit weak. The error message said to adjust the min_snr but it was hardcoded and the user had no way to adjust it. Now it is a parameter to the primitive and it solves the problem.
…l. It was tripping a check. Now it accepts both types.
…sing an occasional crash.
…ces, eg sky emission for some orders and lamp for the others.
This reverts commit 00024c9.
…then the IRDC. The values are wrong but the dict keys should be correct.
…se/4.x, I want to confirm that it works.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #506 +/- ##
==========================================
- Coverage 66.47% 66.36% -0.12%
==========================================
Files 312 313 +1
Lines 38679 38954 +275
==========================================
+ Hits 25712 25851 +139
- Misses 12967 13103 +136
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a bookkeeping merge. There's work from
release/4.xthat need to be added tomaster.merge/4.xwhich containsmasterand therelease/4.xupdates has passed the jenkins tests.