appendCustomParams normalize to IRequestOptions v5#1320
Open
dixonyant wants to merge 6 commits into
Open
Conversation
dixonyant
commented
Jun 12, 2026
dixonyant
commented
Contributor
- added IRequestFlags interface
- added IRequestFlags interface
Contributor
Minimum allowed line rate is |
patrickarlt
requested changes
Jul 1, 2026
patrickarlt
left a comment
patrickarlt
left a comment
Contributor
There was a problem hiding this comment.
@dixonyant one change.
Comment on lines
+109
to
+112
| headers: { | ||
| ...(defaultRequestOptions.fetchOptions?.headers as any), | ||
| ...(normalizedRequestOptions.fetchOptions?.headers as any) | ||
| } |
Contributor
There was a problem hiding this comment.
@dixonyant I think that this needs to use the new merge header util that was added at some point. Unless normalizedRequestOptions and defaultRequestOptions both return the headers as an object?
Contributor
There was a problem hiding this comment.
Actually looking at this is is normalize to an object so this works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.