Skip to content

Open links banner in new tab #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jsuarezwd wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Open links banner in new tab #236

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Web/Views/Home/_partials/Banner.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,14 @@
switch (selector)
{
case 1:
<a href="https://bit.ly/xam-dev"><img class="img-fluid" src="~/img/banners/megsoft-job.png" /></a>
<a href="https://bit.ly/xam-dev" target="_blank()"><img class="img-fluid" src="~/img/banners/megsoft-job.png" /></a>

@robertlluberes robertlluberes Nov 10, 2022

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Junior @jsuarezwd , the target attribute should have the value _blank instead of _blank(), also I consider we should include the attribute rel with the values noopener noreferrer for security reasons. See suggested changes:

Suggested change
<a href="https://bit.ly/xam-dev" target="_blank()"><img class="img-fluid" src="~/img/banners/megsoft-job.png" /></a>
<a href="https://bit.ly/xam-dev" target="_blank" rel="noopener noreferrer"><img class="img-fluid" src="~/img/banners/megsoft-job.png" /></a>

Can you please apply those changes to each banner?

Source:

break;
case 2:
<a href="http://devhiring.com/qa-automation-engineer/"><img class="img-fluid" src="~/img/banners/devhire3.png" /></a>
<a href="http://devhiring.com/qa-automation-engineer/" target="_blank()"><img class="img-fluid" src="~/img/banners/devhire3.png" /></a>
break;
case 3:
<a href="https://bit.ly/newtech-empleado"><img class="img-fluid" src="~/img/banners/newtech.png" /></a>
<a href="https://bit.ly/newtech-empleado" target="_blank()"><img class="img-fluid" src="~/img/banners/newtech.png" /></a>
break;
}
}
</div>
</div>