Improve kBool type#778
Open
MichaelS239 wants to merge 4 commits into
Open
Conversation
MichaelS239
force-pushed
the
improve-bool-type
branch
from
e31223a to
8ff39a1
Compare
Handle integer and non-integer representations of bools
separately to ensure correct type deduction for cases when
one column contains both integers and bools.
The following rules for type deduction were ensured:
- {0, 1} -> kInt
- {true, false, t, f, 0, 1} -> kBool
- {0, 1, 2, true} -> kMixed
- {true, false, string} -> kMixed
- {t, f, string} -> kString
MichaelS239
force-pushed
the
improve-bool-type
branch
from
8ff39a1 to
140bb78
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds various fixes and improvements for kBool type:
builtin.h