fix: FdFirst options and refactor CFDRelationData class#771
Open
Oddin60F wants to merge 2 commits into
Open
Conversation
wildsor
requested changes
May 27, 2026
| DESBORDANTE_OPTION_USING; | ||
|
|
||
| auto check_num_cols = [this](unsigned int val) { | ||
| if (OptionIsSet(kCfdTuplesNumber) && (tuples_number_ != 0 && val == 0)) { |
Collaborator
There was a problem hiding this comment.
Use SetConditionalOpts with empty condition, like in MetricVerifier (kMetric option)
| // predicate is equivalent to an always-true predicate, and thus must | ||
| // always be last. | ||
| Option& SetConditionalOpts(OptCondVector opt_cond) { | ||
| assert(opt_cond_.empty()); |
Collaborator
|
The assert says that |
Oddin60F
changed the title
Collaborator
|
Could you be more specific on what was done to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FdFirst options:
Added parameter verification during loading. Previously, an incorrect parameter caused an error when running the algorithm, not when loading the parameters.
CFDRelationData:
The number of rows and columns parameters for loading a part of the table into the algorithm has been removed.