Add optional PLIWS#748
Open
Sneper-Breeze wants to merge 3 commits into
Open
Conversation
wildsor
reviewed
May 2, 2026
c4e36ba to
b9d7ed5
Compare
wildsor
reviewed
May 17, 2026
mitya-radivonchik
suggested changes
May 18, 2026
mitya-radivonchik
approved these changes
May 26, 2026
b6203e3 to
f6c5724
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes Tane and AfdMetricCalc use PLIWS only when explicitly enabled via a boolean flag.
Changes:
In AfdMetricCalc (src/core/algorithms/fd/afd_metric):
std::variantto select between PLI and PLIWS based on theuse_pliwsflag (default: false).In TaneCommon:
std::variantto work with both PLI and PLIWS.Behavior:
use_pliwsparameter (default false) can now be passed at algorithm creation.Testing: