Handle whitespace in Bash variables.#46
Closed
will-ca wants to merge 6 commits into
Closed
Conversation
- Searched for `(?<!")(\\\$[a-zA-Z]+[a-zA-Z0-9_]*)`. - In text editor, unchecked any matches that aren't a naked variable. - Replaced with `"\1"`.
…hitespace separation in `runtimeScript`.
…nt lists in `runtimeScript`.
|
fixed in #151 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See commit list for summary of the types of changes.
Attempts to close #44.
In theory I think this is everything that would need to be done.
However, note that this currently breaks
nix-portablewithnix/store/zbabf0j2wibf6y74xyz80im3m2jk9bmn-libssh2-1.10.0: not found in archive.I've elected not to further pursue this option in the application that I originally intended to use it for, so the best I can do is to offer this PR as-is for consideration.
Hopefully the remaining problems will be obvious and easily fixed by somebody more familiar with the inner workings of Nix and
nix-portable, but perhaps not.