fix: resolve Vite import errors and safely handle process.env#17
Open
sprzedawcaMily wants to merge 1 commit into
Open
fix: resolve Vite import errors and safely handle process.env#17sprzedawcaMily wants to merge 1 commit into
sprzedawcaMily wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses issues where the library crashed or failed to resolve when imported in modern browser-based environments like Vite or React.
Changes Made
"module": "src/index.ts"entry from package.json that was causing ESM resolution failures, and replaced it with a proper"exports"map to correctly route to compiled .ts declarations and.jsbundles.process.envreferences in config.ts with a safe getEnv function. It now smoothly falls back whenprocessis undefined instead of throwing a critical ReferenceError.apiUrland verbose fallback properties directly into the LibreLinkClientOptions interface, allowing developers to cleanly pass config keys via the constructor without needing Node environment processes.How to Test
npm run build).npm run test).distfiles inside a fresh Vite template (e.g.,npm create vite@latest) and verify the library doesn't throw a module orprocesserror in the browser console.