Skip to content

Remove reordering of existing cases [ON HOLD]#5166

Open
diitaz93 wants to merge 21 commits into
masterfrom
stop-ordering-existing-cases
Open

Remove reordering of existing cases [ON HOLD]#5166
diitaz93 wants to merge 21 commits into
masterfrom
stop-ordering-existing-cases

Conversation

@diitaz93

@diitaz93 diitaz93 commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

DO NOT MERGE UNTIL CUSTOMERS ARE INFORMED

Description

Important: Has to be merged after https://github.com/Clinical-Genomics/clinical-genomics-ui/pull/919
Remove validation and support for ordering existing cases.

Changed

  • Remove class ExistingCase and all its usages
  • Remove validation regarding any aspect of ExistingCase
  • Simplified cases validation in OrderWithCases by removing the annotations "New" and "Existing"
  • Change the Pydantic Error handling by not expecting annotations in the loc section for case errors
  • Remove property is_new from Case base model and all logic around it
  • Simplified case enumeration in OrderWithCases

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta):
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b stop-ordering-existing-cases -a

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@diitaz93 diitaz93 linked an issue Jun 29, 2026 that may be closed by this pull request
@sonarqubecloud

sonarqubecloud Bot commented Jul 7, 2026

Copy link
Copy Markdown

@diitaz93
diitaz93 marked this pull request as ready for review July 7, 2026 10:23
@diitaz93
diitaz93 requested a review from a team as a code owner July 7, 2026 10:23

@RasmusBurge-CG RasmusBurge-CG left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎉

@diitaz93 diitaz93 changed the title Remove reordering of existing cases Remove reordering of existing cases [ON HOLD] Jul 7, 2026
@clingen-sthlm
clingen-sthlm temporarily deployed to stage July 8, 2026 11:21 Inactive
@diitaz93

diitaz93 commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

Tests in stage

  • Field validation works
  • Submitted orders for Raredisease and BALSAMIC
  • Existing case field does not appear (Front-end)

Comment thread cg/meta/orders/utils.py
from cg.constants.priority import Priority
from cg.models.orders.constants import OrderType
from cg.services.orders.constants import ORDER_TYPE_WORKFLOW_MAP
from cg.services.orders.validation.models.existing_sample import ExistingSample

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment to hold accidental merge to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the possibilty to re-order case

3 participants