Skip to content

fix(nullable): clear pointer destinations on null rows#1926

Open
014-code wants to merge 1 commit into
ClickHouse:mainfrom
014-code:issue-1730
Open

fix(nullable): clear pointer destinations on null rows#1926
014-code wants to merge 1 commit into
ClickHouse:mainfrom
014-code:issue-1730

Conversation

@014-code

Copy link
Copy Markdown

Summary

  • Clear pointer-to-pointer scan destinations when Nullable returns NULL, so reused dynamic scan variables no longer keep the previous decimal value.
  • Add a unit test for Nullable clearing **decimal.Decimal.
  • Add a regression test for Unexpected behavior when scanning Nullable(Decimal64(2)) column #1730 covering Nullable(Decimal64(2)) with repeated dynamic scanning.

Related issue

Closes #1730

Testing

  • go test ./lib/column
  • go test ./tests/issues -run Test1730NullableDecimalDynamicScan -count=1 -v (compiled, skipped on this host because Docker is unavailable)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unexpected behavior when scanning Nullable(Decimal64(2)) column

1 participant