chore: add debug visibility on bad connection pool#1920
Draft
kavirajk wants to merge 1 commit into
Draft
Conversation
Currently, if for some reason, the connection from pool is bad and client end up dialing (establishing) new connection instead, the only visibility in debug log is either "connection acquired from pool" or "new connection is established". But this lacks "why" the connection was bad that caused to create new connection. This changes makes sure those reasons are part of debug log Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
kavirajk
commented
Jul 16, 2026
| } | ||
|
|
||
| func (c *connect) isBad() bool { | ||
| func (c *connect) healthCheck() error { |
Contributor
Author
There was a problem hiding this comment.
This is the main change that adds more visibility on debug log on "why connection is not re-used from the pool"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently, if for some reason, the connection from pool is bad and client end up dialing (establishing) new connection instead, the only visibility in debug log is either "connection acquired from pool" or "new connection is established".
But this lacks "why" the connection was bad that caused to create new connection.
This changes makes sure those reasons are part of debug log
This is built on top of v2.47.0 tag instead of from
main. DO NOT MERGE THIS as is, this is to help some ClickHouse customer to experiment with to track some performance bugsRelated to #1915
Checklist
Delete items not relevant to your PR: