feat: support disabling pooling for a persona#105
Closed
btrautmann wants to merge 3 commits into
Closed
Conversation
smudge
reviewed
Apr 27, 2026
Member
There was a problem hiding this comment.
Idea: what if we add an after_claim callback config, so that anything time-sensitive can be created or updated at the time when the persona is claimed for use?
Contributor
Author
There was a problem hiding this comment.
Oh that's a super neat idea, lemme look into that
Contributor
Author
|
Closing in favor of #106. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows for disabling pooling behavior for a given persona.
This is useful in some cases where a persona has behavior/attributes that are time-sensitive, i.e. an expiring invite or similar that, if pooled, would expire prior to being claimed.
By setting
allow_in_pool { false }, you disable pooling and a new persona will always be generated when requested. The persona will never be hydrated.