fix query parameters template for WithSecureElementsCCF#14619
Open
gloo-shock wants to merge 2 commits into
Open
fix query parameters template for WithSecureElementsCCF#14619gloo-shock wants to merge 2 commits into
gloo-shock wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Fixes the WithSecureElementsCCF connector’s ARM-templated request construction so the “Connect” flow can successfully authenticate and produce a valid security-events request payload.
Changes:
- Adds
WithSecureElementsCCFas a workbook metadata dependency in the packaged template. - Replaces placeholder Basic-auth header with an ARM expression intended to build
Authorization: Basic <base64(clientId:clientSecret)>. - Reworks
queryParametersTemplateto keepengine/engineGroupmutually exclusive and defaultengineGroupwhen optional inputs are empty/placeholders.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| Solutions/WithSecureElementsCCF/Package/mainTemplate.json | Updates packaged template dependencies and templated headers/body for token + security-events requests |
| Solutions/WithSecureElementsCCF/Data/Solution_WithSecureElementsCCF.json | Adjusts solution metadata (Author contact, BasePath) |
| Solutions/WithSecureElementsCCF/Data Connectors/WithSecureElementsCCP/WithSecureElements_PollerConfig.json | Updates connector poller config token auth header and request body generation |
v-shukore
previously approved these changes
Jul 3, 2026
Contributor
|
Hi @gloo-shock, could you let me know why the basepath was removed from the data file? Please revert it as old one. Thanks! |
Contributor
Author
@v-shukore done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the follow up PR to this PR (@v-shukore )
Change(s):
WithSecureElements_PollerConfig.json) and regenerated Package (mainTemplate.json,3.0.0.zip):Authorizationheader now builds the HTTP Basic credential via an ARM expression[concat('Basic ', base64(concat(parameters('ClientId'), ':', parameters('ClientSecret'))))]instead of the invalidBasic {{base64(ClientId:ClientSecret)}}placeholder.security-eventsrequest body (queryParametersTemplate): theengine/engineGroupselection now falls back to the default engine group (epp,edr,ecp,xm) when the optional field is left empty or still holds the packaging placeholder, and keepsengine/engineGroupmutually exclusive.WithSecureElementsCCFDataConnector to the workbook metadata dependencies.Solution_WithSecureElementsCCF.json: added a support contact email to theAuthorfield and correctedBasePath.Reason for Change(s):
POST /as/token.oauth2("Invalid Credential") because Sentinel CCF does not honorIsClientSecretInHeaderand did not send anAuthorization: Basicheader.POST /security-events/v1/security-eventsbecause the V3 packaging tool auto-generates the nested-template parameter defaults from the connector's textbox names, so a blank optional field produced an invalid"engineGroup":[""]/["engineGroup"]value that the Elements API rejects.Version Updated:
Testing Completed:
security-eventspoll returns 200 with events ingested into the custom table. The packaged3.0.0.zipwas regenerated with the V3 tool and verified to contain the fixes.Checked that the validations are passing and have addressed any issues that are present:
contentProductId/id, which the V3 README states can be ignored.createUiDefinition.json,mainTemplate.jsonandtestParameters.jsonall validate as valid JSON.