Adding msg_s column in AzureFirewall DNS parsers#14609
Open
dhanunjaya1054 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the Azure Firewall DNS ASIM parsers to safely reference msg_s in AzureDiagnostics by using column_ifexists, preventing unions from failing when the column is absent (e.g., resource-specific logging scenarios).
Changes:
- Bumped parser versions from
0.4.0to0.4.1and updatedLastUpdateddates. - Added
extend msg_s = column_ifexists("msg_s", "")to legacyAzureDiagnosticsbranches in both parsers. - Added explanatory comments describing why
column_ifexistsis required.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Parsers/ASimDns/Parsers/vimDnsAzureFirewall.yaml | Makes msg_s access safe in AzureDiagnostics DNS proxy branches to avoid union aborts. |
| Parsers/ASimDns/Parsers/ASimDnsAzureFirewall.yaml | Same msg_s safety fix for the main ASIM parser, plus version/date bump. |
Comment on lines
+61
to
62
| | extend msg_s = column_ifexists("msg_s", "") | ||
| | project msg_s, TimeGenerated, ResourceId, SubscriptionId |
Comment on lines
+61
to
63
| | extend msg_s = column_ifexists("msg_s", "") | ||
| | project msg_s, TimeGenerated, ResourceId, SubscriptionId | ||
| | where msg_s startswith " Error:" |
Collaborator
|
@dhanunjaya1054 Update the changelog files that you've made the change to the two parsers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required items, please complete
Change(s):
Reason for Change(s):
Version Updated:
Testing Completed: