Data Connector Naming Fix in ARM Main Template#14583
Open
dhanunjaya1054 wants to merge 1 commit into
Open
Conversation
…ng the stray '{{GUID}}' suffix from the poller name expressions.
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Fixes the VMware Workspace ONE data connector naming so deployments don’t fail with “content template not found” due to a corrupted connector/poller name.
Changes:
- Updates data connector resource names to remove the stray
{{GUID}}suffix. - Modifies ARM/poller config expressions and conditional logic around
collectAppsDetails. - Bumps the poller config
apiVersion.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 10 comments.
| File | Description |
|---|---|
| Solutions/VMware Workspace ONE/Package/mainTemplate.json | Adjusts ARM template parameters and data connector resource definitions, including connector names and conditions. |
| Solutions/VMware Workspace ONE/Data Connectors/VMwareWorkspaceOneConnector_CCF/VMwareWorkspaceOne_PollerConfig.json | Updates poller config connector names and related ARM expressions, and changes the apiVersion. |
Comment on lines
+1163
to
+1164
| "defaultValue": "collectAppsDetails", | ||
| "type": "array" |
| }, | ||
| { | ||
| "name": "[[concat([concat(parameters('workspace'), ', '/Microsoft.SecurityInsights', '/', 'VMwareWorkspaceOneDevices_CL', uniqueString(parameters('friendlyName')), '-', '')]', parameters('GUID'), parameters('guidValue'))]", | ||
| "name": "[[concat('parameters('workspace')', '/Microsoft.SecurityInsights/','VMwareWorkspaceOneDevices_CL' , uniqueString(parameters('friendlyName')) )]", |
Comment on lines
+1206
to
+1211
| "ClientId": "[[parameters('clientId')]", | ||
| "ClientSecret": "[[parameters('clientSecret')]", | ||
| "GrantType": "client_credentials", | ||
| "TokenEndpoint": "[concat(parameters('authUrl'), '/connect/token')]", | ||
| "TokenEndpoint": "[[concat(parameters('authUrl'), '/connect/token')]", | ||
| "TokenEndpointHeaders": { | ||
| "Authorization": "[concat('Basic ', base64(concat(parameters('clientId'), ':', parameters('clientSecret'))))]", | ||
| "Authorization": "[[concat('Basic ', base64(concat(parameters('clientId'), ':', parameters('clientSecret'))))]", |
| }, | ||
| "request": { | ||
| "apiEndpoint": "[concat(parameters('instanceUrl'), '/api/mdm/devices/search')]", | ||
| "apiEndpoint": "[[concat(parameters('instanceUrl'), '/api/mdm/devices/search')]", |
| @@ -1244,31 +1244,31 @@ | |||
| "dataCollectionRuleImmutableId": "[[parameters('dcrConfig').dataCollectionRuleImmutableId]" | |||
| } | ||
| }, | ||
| "condition": "[equals(parameters('collectAppsDetails'), 'true')]" | ||
| "condition": "[[contains(parameters('collectAppsDetails'), 'true')]" |
Comment on lines
+4
to
+5
| "apiVersion": "2024-09-01", | ||
| "name": "[[concat('parameters('workspace')', '/Microsoft.SecurityInsights/','VMwareWorkspaceOneDevices_CL' , uniqueString(parameters('friendlyName')) )]", |
Comment on lines
+11
to
+16
| "ClientId": "[[parameters('clientId')]", | ||
| "ClientSecret": "[[parameters('clientSecret')]", | ||
| "GrantType": "client_credentials", | ||
| "TokenEndpoint": "[concat(parameters('authUrl'), '/connect/token')]", | ||
| "TokenEndpoint": "[[concat(parameters('authUrl'), '/connect/token')]", | ||
| "TokenEndpointHeaders": { | ||
| "Authorization": "[concat('Basic ', base64(concat(parameters('clientId'), ':', parameters('clientSecret'))))]", | ||
| "Authorization": "[[concat('Basic ', base64(concat(parameters('clientId'), ':', parameters('clientSecret'))))]", |
| }, | ||
| "request": { | ||
| "apiEndpoint": "[concat(parameters('instanceUrl'), '/api/mdm/devices/search')]", | ||
| "apiEndpoint": "[[concat(parameters('instanceUrl'), '/api/mdm/devices/search')]", |
| } | ||
| }, | ||
| "condition": "[equals(parameters('collectAppsDetails'), 'true')]" | ||
| "condition": "[[contains(parameters('collectAppsDetails'), 'true')]" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change(s):
PollerConfig.json file.
Reason for Change(s):
Version Updated:
Testing Completed: