[SalesforceAuditLogsConnector] Remove LoginGeoId from LoginHistory query and refresh generated artifacts#14566
Open
v-hectorarv wants to merge 2 commits into
Open
Conversation
…acts This PR updates the Salesforce Audit Logs connector to remove the LoginGeoId field from the LoginHistory polling query. The change keeps the connector aligned with the intended payload/schema handling for Login History ingestion and refreshes generated artifacts accordingly. It also updates sample input timestamps to consistent timezone-offset values while preserving event chronology.
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR updates the Salesforce Audit Logs connector to remove LoginGeoId from the LoginHistory SOQL polling query and refreshes the generated solution artifacts and versioning to match.
Changes:
- Removed
LoginGeoIdfrom theLoginHistorypolling SOQL query. - Bumped solution/package versions to
3.5.0and refreshed generated artifacts (ARM template, polling config). - Adjusted a KQL transform’s null/empty handling for
EventDatein the solution template.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Solutions/Salesforce Service Cloud/ReleaseNotes.md | Adds 3.5.0 release entry documenting the LoginGeoId query change. |
| Solutions/Salesforce Service Cloud/Package/mainTemplate.json | Bumps versions to 3.5.0, updates SOQL query, and updates generated template strings/metadata. |
| Solutions/Salesforce Service Cloud/Data/Solution_TSalesforceCloudtemplateSpec.json | Updates solution version to 3.5.0 for template spec packaging. |
| Solutions/Salesforce Service Cloud/Data Connectors/SalesforceAuditLogsConnector_CCF/SalesforceAuditLogs_PollingConfig.json | Removes LoginGeoId from the LoginHistory polling query. |
| ], | ||
| "outputStream": "Custom-SalesForceRealTimeEventMonitoring_CL", | ||
| "transformKql": "source | project TimeGenerated=iff(isempty(EventDate),now(),todatetime(EventDate)),EventType=EventType,EventDate=EventDate,EventIdentifier=EventIdentifier,UserId=UserId,LoginKey=LoginKey,SessionKey=SessionKey,SourceIp=SourceIp,EvaluationTime=EvaluationTime,PolicyId=PolicyId,PolicyOutcome=PolicyOutcome,SessionLevel=SessionLevel,RelatedEventIdentifier=RelatedEventIdentifier,LoginHistoryId=LoginHistoryId,CreatedDate=CreatedDate,EventUuid=EventUuid,ReplayId=ReplayId,CreatedById=CreatedById,LastReferencedDate=LastReferencedDate,LastViewedDate=LastViewedDate,QueriedEntities=QueriedEntities,Score=Score,Summary=Summary,Operation=Operation,SecurityEventData=SecurityEventData,RowsProcessed=RowsProcessed,UserAgent=UserAgent,UserType=UserType,Application=Application,LoginType=LoginType,Name=Name,Platform=Platform,Records=Records,ActionName=ActionName,AdditionalInfo=AdditionalInfo,AnomalySubType=AnomalySubType,ApiType=ApiType,AppName=AppName,BotId=BotId,BotSessionIdentifier=BotSessionIdentifier,Browser=Browser,City=City,ColumnHeaders=ColumnHeaders,Country=Country,CountryIso=CountryIso,EventSource=EventSource,ExecutionIdentifier=ExecutionIdentifier,LoginUrl=LoginUrl,NumberOfColumns=NumberOfColumns,OwnerId=OwnerId,PlannerId=PlannerId,PostalCode=PostalCode,Query=Query,RecordId=RecordId,RequestIdentifier=RequestIdentifier,Scope=Scope,Sequence=Sequence,Subdivision=Subdivision,AcceptLanguage=AcceptLanguage,Activity=Activity,ApiAnomalyEventNumber=ApiAnomalyEventNumber,ApiVersionNumber=ApiVersionNumber,ApiVersion=ApiVersion,AppId=AppId,AuthMethodReference=AuthMethodReference,AuthServiceId=AuthServiceId,AuthSessionId=AuthSessionId,CanDownloadPdf=CanDownloadPdf,CipherSuite=CipherSuite,Client=Client,ClientVersion=ClientVersion,ConnectedAppId=ConnectedAppId,ConnectionType=ConnectionType,ContentSize=ContentSize,CredentialStuffingEventNumber=CredentialStuffingEventNumber,CurrentIp=CurrentIp,CurrentPlatform=CurrentPlatform,CurrentScreen=CurrentScreen,CurrentUserAgent=CurrentUserAgent,CurrentWindow=CurrentWindow,DashboardId=DashboardId,DashboardName=DashboardName,DelegatedOrganizationId=DelegatedOrganizationId,DelegatedUsername=DelegatedUsername,Description=Description,DeveloperName=DeveloperName,DeviceId=DeviceId,DeviceModel=DeviceModel,DevicePlatform=DevicePlatform,DeviceSessionId=DeviceSessionId,DisplayedFieldEntities=DisplayedFieldEntities,DocumentId=DocumentId,Duration=Duration,EffectivePageTime=EffectivePageTime,EffectivePageTimeDeviationErrorType=EffectivePageTimeDeviationErrorType,EffectivePageTimeDeviationReason=EffectivePageTimeDeviationReason,ElapsedTime=ElapsedTime,ErrorCode=ErrorCode,EventGroup=EventGroup,EventSourceDetail=EventSourceDetail,ExportFileFormat=ExportFileFormat,FeatureContribution=FeatureContribution,FeatureName=FeatureName,FeatureValue=FeatureValue,FileAction=FileAction,FileName=FileName,FileSource=FileSource,FileType=FileType,FilterCriteria=FilterCriteria,Format=Format,ForwardedForIp=ForwardedForIp,GroupedColumnHeaders=GroupedColumnHeaders,GuestUserAnomalyEventNumber=GuestUserAnomalyEventNumber,HasEffectivePageTimeDeviation=HasEffectivePageTimeDeviation,HasExternalUsers=HasExternalUsers,HasLogoutUrl=HasLogoutUrl,HttpMethod=HttpMethod,HttpReferer=HttpReferer,SalesforceObjectId=Id,IdentityUsed=IdentityUsed,ImpactedUserIds=ImpactedUserIds,InitiatedBy=InitiatedBy,IsLatestVersion=IsLatestVersion,IsScheduled=IsScheduled,Latitude=Latitude,ListViewId=ListViewId,LoginAnomalyEventNumber=LoginAnomalyEventNumber,LoginAsCategory=LoginAsCategory,LoginAccessChangeExpDate=LoginAccessChangeExpDate,LoginAccessChangeGranteeName=LoginAccessChangeGranteeName,LoginAccessChangeGranteeType=LoginAccessChangeGranteeType,LoginGeoId=LoginGeoId,LoginLatitude=LoginLatitude,LoginLongitude=LoginLongitude,LoginSubType=LoginSubType,Longitude=Longitude,Message=Message,NetworkId=NetworkId,OperationDetail=OperationDetail,OperationStatus=OperationStatus,OrderBy=OrderBy,OsName=OsName,OsVersion=OsVersion,PageStartTime=PageStartTime,PageUrl=PageUrl,ParentIdList=ParentIdList,ParentNameList=ParentNameList,PermissionExpiration=PermissionExpiration,PermissionExpirationList=PermissionExpirationList,PermissionList=PermissionList,PermissionType=PermissionType,Policy=Policy,PreviousIp=PreviousIp,PreviousPageAppName=PreviousPageAppName,PreviousPageEntityId=PreviousPageEntityId,PreviousPageEntityType=PreviousPageEntityType,PreviousPageUrl=PreviousPageUrl,PreviousPlatform=PreviousPlatform,PreviousScreen=PreviousScreen,PreviousUserAgent=PreviousUserAgent,PreviousWindow=PreviousWindow,ProcessDuration=ProcessDuration,Remarks=Remarks,RemoteIdentifier=RemoteIdentifier,Report=Report,ReportAnomalyEventNumber=ReportAnomalyEventNumber,ReportId=ReportId,RequestedEntities=RequestedEntities,SalesforceResourceId=ResourceId,RowsReturned=RowsReturned,SamlEntityUrl=SamlEntityUrl,SdkAppType=SdkAppType,SdkAppVersion=SdkAppVersion,SdkVersion=SdkVersion,SessionHijackingEventNumber=SessionHijackingEventNumber,SoqlCommands=SoqlCommands,SsoType=SsoType,Status=Status,StatusDetail=StatusDetail,TargetUrl=TargetUrl,TlsProtocol=TlsProtocol,TotalControllerEvents=TotalControllerEvents,Uri=Uri,UseApiToken=UseApiToken,UserAgentDetail=UserAgentDetail,UserCount=UserCount,UserNameDetail=UserName,UserTypeDetail=UserTypeDetail,VerificationMethod=VerificationMethod,VersionId=VersionId,VersionNumber=VersionNumber" | ||
| "transformKql": "source | project TimeGenerated=iff(isnull(EventDate),now(),todatetime(EventDate)),EventType=EventType,EventDate=EventDate,EventIdentifier=EventIdentifier,UserId=UserId,LoginKey=LoginKey,SessionKey=SessionKey,SourceIp=SourceIp,EvaluationTime=EvaluationTime,PolicyId=PolicyId,PolicyOutcome=PolicyOutcome,SessionLevel=SessionLevel,RelatedEventIdentifier=RelatedEventIdentifier,LoginHistoryId=LoginHistoryId,CreatedDate=CreatedDate,EventUuid=EventUuid,ReplayId=ReplayId,CreatedById=CreatedById,LastReferencedDate=LastReferencedDate,LastViewedDate=LastViewedDate,QueriedEntities=QueriedEntities,Score=Score,Summary=Summary,Operation=Operation,SecurityEventData=SecurityEventData,RowsProcessed=RowsProcessed,UserAgent=UserAgent,UserType=UserType,Application=Application,LoginType=LoginType,Name=Name,Platform=Platform,Records=Records,ActionName=ActionName,AdditionalInfo=AdditionalInfo,AnomalySubType=AnomalySubType,ApiType=ApiType,AppName=AppName,BotId=BotId,BotSessionIdentifier=BotSessionIdentifier,Browser=Browser,City=City,ColumnHeaders=ColumnHeaders,Country=Country,CountryIso=CountryIso,EventSource=EventSource,ExecutionIdentifier=ExecutionIdentifier,LoginUrl=LoginUrl,NumberOfColumns=NumberOfColumns,OwnerId=OwnerId,PlannerId=PlannerId,PostalCode=PostalCode,Query=Query,RecordId=RecordId,RequestIdentifier=RequestIdentifier,Scope=Scope,Sequence=Sequence,Subdivision=Subdivision,AcceptLanguage=AcceptLanguage,Activity=Activity,ApiAnomalyEventNumber=ApiAnomalyEventNumber,ApiVersionNumber=ApiVersionNumber,ApiVersion=ApiVersion,AppId=AppId,AuthMethodReference=AuthMethodReference,AuthServiceId=AuthServiceId,AuthSessionId=AuthSessionId,CanDownloadPdf=CanDownloadPdf,CipherSuite=CipherSuite,Client=Client,ClientVersion=ClientVersion,ConnectedAppId=ConnectedAppId,ConnectionType=ConnectionType,ContentSize=ContentSize,CredentialStuffingEventNumber=CredentialStuffingEventNumber,CurrentIp=CurrentIp,CurrentPlatform=CurrentPlatform,CurrentScreen=CurrentScreen,CurrentUserAgent=CurrentUserAgent,CurrentWindow=CurrentWindow,DashboardId=DashboardId,DashboardName=DashboardName,DelegatedOrganizationId=DelegatedOrganizationId,DelegatedUsername=DelegatedUsername,Description=Description,DeveloperName=DeveloperName,DeviceId=DeviceId,DeviceModel=DeviceModel,DevicePlatform=DevicePlatform,DeviceSessionId=DeviceSessionId,DisplayedFieldEntities=DisplayedFieldEntities,DocumentId=DocumentId,Duration=Duration,EffectivePageTime=EffectivePageTime,EffectivePageTimeDeviationErrorType=EffectivePageTimeDeviationErrorType,EffectivePageTimeDeviationReason=EffectivePageTimeDeviationReason,ElapsedTime=ElapsedTime,ErrorCode=ErrorCode,EventGroup=EventGroup,EventSourceDetail=EventSourceDetail,ExportFileFormat=ExportFileFormat,FeatureContribution=FeatureContribution,FeatureName=FeatureName,FeatureValue=FeatureValue,FileAction=FileAction,FileName=FileName,FileSource=FileSource,FileType=FileType,FilterCriteria=FilterCriteria,Format=Format,ForwardedForIp=ForwardedForIp,GroupedColumnHeaders=GroupedColumnHeaders,GuestUserAnomalyEventNumber=GuestUserAnomalyEventNumber,HasEffectivePageTimeDeviation=HasEffectivePageTimeDeviation,HasExternalUsers=HasExternalUsers,HasLogoutUrl=HasLogoutUrl,HttpMethod=HttpMethod,HttpReferer=HttpReferer,SalesforceObjectId=Id,IdentityUsed=IdentityUsed,ImpactedUserIds=ImpactedUserIds,InitiatedBy=InitiatedBy,IsLatestVersion=IsLatestVersion,IsScheduled=IsScheduled,Latitude=Latitude,ListViewId=ListViewId,LoginAnomalyEventNumber=LoginAnomalyEventNumber,LoginAsCategory=LoginAsCategory,LoginAccessChangeExpDate=LoginAccessChangeExpDate,LoginAccessChangeGranteeName=LoginAccessChangeGranteeName,LoginAccessChangeGranteeType=LoginAccessChangeGranteeType,LoginGeoId=LoginGeoId,LoginLatitude=LoginLatitude,LoginLongitude=LoginLongitude,LoginSubType=LoginSubType,Longitude=Longitude,Message=Message,NetworkId=NetworkId,OperationDetail=OperationDetail,OperationStatus=OperationStatus,OrderBy=OrderBy,OsName=OsName,OsVersion=OsVersion,PageStartTime=PageStartTime,PageUrl=PageUrl,ParentIdList=ParentIdList,ParentNameList=ParentNameList,PermissionExpiration=PermissionExpiration,PermissionExpirationList=PermissionExpirationList,PermissionList=PermissionList,PermissionType=PermissionType,Policy=Policy,PreviousIp=PreviousIp,PreviousPageAppName=PreviousPageAppName,PreviousPageEntityId=PreviousPageEntityId,PreviousPageEntityType=PreviousPageEntityType,PreviousPageUrl=PreviousPageUrl,PreviousPlatform=PreviousPlatform,PreviousScreen=PreviousScreen,PreviousUserAgent=PreviousUserAgent,PreviousWindow=PreviousWindow,ProcessDuration=ProcessDuration,Remarks=Remarks,RemoteIdentifier=RemoteIdentifier,Report=Report,ReportAnomalyEventNumber=ReportAnomalyEventNumber,ReportId=ReportId,RequestedEntities=RequestedEntities,SalesforceResourceId=ResourceId,RowsReturned=RowsReturned,SamlEntityUrl=SamlEntityUrl,SdkAppType=SdkAppType,SdkAppVersion=SdkAppVersion,SdkVersion=SdkVersion,SessionHijackingEventNumber=SessionHijackingEventNumber,SoqlCommands=SoqlCommands,SsoType=SsoType,Status=Status,StatusDetail=StatusDetail,TargetUrl=TargetUrl,TlsProtocol=TlsProtocol,TotalControllerEvents=TotalControllerEvents,Uri=Uri,UseApiToken=UseApiToken,UserAgentDetail=UserAgentDetail,UserCount=UserCount,UserNameDetail=UserName,UserTypeDetail=UserTypeDetail,VerificationMethod=VerificationMethod,VersionId=VersionId,VersionNumber=VersionNumber" |
| { | ||
| "provider": "Microsoft.OperationalInsights/workspaces", | ||
| "permissionsDisplayText": "Read and Write permissions are required.", | ||
| "permissionsDisplayText": "Read, Write, and Delete permissions are required.", |
| { | ||
| "provider": "Microsoft.OperationalInsights/workspaces", | ||
| "permissionsDisplayText": "Read and Write permissions are required.", | ||
| "permissionsDisplayText": "Read, Write, and Delete permissions are required.", |
Contributor
|
Hi @v-hectorarv Kindly review the above comments, address them if needed, and mark them as resolved. Thanks! |
Contributor
|
Hi @v-hectorarv Kindly review the above comments. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the Salesforce Audit Logs connector to remove the LoginGeoId field from the LoginHistory polling query. The change keeps the connector aligned with the intended payload/schema handling for Login History ingestion and refreshes generated artifacts accordingly. It also updates sample input timestamps to consistent timezone-offset values while preserving event chronology.
Changes
Generated Artifacts
Testing
Related Issue
Resolves: https://msdata.visualstudio.com/Sentinel%20Graph/_workitems/edit/5358823
Checklist