Skip to content

Fix eDCRule Partner Center metadata and logo#14555

Open
aceredc-Lancy wants to merge 4 commits into
Azure:masterfrom
aceredc-Lancy:fix-edcrule-solution-id
Open

Fix eDCRule Partner Center metadata and logo#14555
aceredc-Lancy wants to merge 4 commits into
Azure:masterfrom
aceredc-Lancy:fix-edcrule-solution-id

Conversation

@aceredc-Lancy

Copy link
Copy Markdown
Contributor

Proposed changes

This PR updates the eDCRule Microsoft Sentinel solution package to address Partner Center validation feedback.

Changes include:

  • Updated SolutionMetadata publisherId to match the Partner Center offer name.
  • Added the eDC company logo asset.
  • Updated the solution Data input file to use the eDC logo.
  • Regenerated the package using the Create-Azure-Sentinel-Solution V3 tool.
  • Rebuilt the package zip with the updated mainTemplate.json and createUiDefinition.json.

Validation

  • mainTemplate.json is valid JSON.
  • createUiDefinition.json is valid JSON.
  • testParameters.json is valid JSON.
  • Package zip contains the updated logo reference.
  • Package zip contains the expected solutionId:
    1633093245661.edc-sentinel-solution
  • No non-ASCII characters remain in package JSON files.

@aceredc-Lancy aceredc-Lancy requested review from a team as code owners June 25, 2026 02:26
@v-maheshbh v-maheshbh added the Solution Solution specialty review needed label Jun 25, 2026
@v-maheshbh v-maheshbh requested a review from Copilot June 25, 2026 04:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates the eDCRule Microsoft Sentinel solution package metadata and branding assets to satisfy Partner Center validation requirements.

Changes:

  • Updated solution publisherId and corresponding solutionId to align with the Partner Center offer/publisher identity.
  • Swapped solution icon/logo references from the Microsoft Sentinel logo to the eDC logo across package artifacts.
  • Regenerated/rebuilt the solution package outputs (mainTemplate.json, createUiDefinition.json) with the updated metadata.

Reviewed changes

Copilot reviewed 4 out of 6 changed files in this pull request and generated 2 comments.

File Description
Solutions/eDCRule/SolutionMetadata.json Updates publisherId used for Partner Center validation alignment.
Solutions/eDCRule/Package/mainTemplate.json Updates solutionId and solution icon to use the eDC logo.
Solutions/eDCRule/Package/createUiDefinition.json Updates UI description to display the eDC logo.
Solutions/eDCRule/Data/Solution_eDCRule.json Updates solution data file to reference the eDC logo.

Comment thread Solutions/eDCRule/Package/mainTemplate.json Outdated
Comment thread Solutions/eDCRule/Package/createUiDefinition.json Outdated
@v-shukore

Copy link
Copy Markdown
Contributor

Hi @aceredc-Lancy, please delete the logo with PNG format to resolve validation failure. Thanks!

@v-shukore

Copy link
Copy Markdown
Contributor

Hi @aceredc-Lancy, could you update the logo path in the data file? Please keep the previous masters folder path, and use your logo there instead of the sentinel logo. Thanks!
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Solution Solution specialty review needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants