Skip to content

[ASIM] Authentication - Salesforce Service Cloud - Codeless Connector Tables Support#14215

Merged
yummyblabla merged 19 commits into
Azure:masterfrom
SpeedyFireCyclone:ASIM/AuthenticationSalesforceSC
Jun 26, 2026
Merged

[ASIM] Authentication - Salesforce Service Cloud - Codeless Connector Tables Support#14215
yummyblabla merged 19 commits into
Azure:masterfrom
SpeedyFireCyclone:ASIM/AuthenticationSalesforceSC

Conversation

@SpeedyFireCyclone

@SpeedyFireCyclone SpeedyFireCyclone commented May 6, 2026

Copy link
Copy Markdown
Contributor

Required items, please complete

Change(s):

  • Add support for codeless connector via SalesforceServiceCloudV2_CL table
  • Update unifying parser with pack parameter for the updated parser
  • Add support for updated connector via SalesforceServiceCloudV3_CL table

Reason for Change(s):

  • Support parsing logs from the latest codeless connector

Version Updated:

  • Yes

Testing Completed:

  • Yes

Checked that the validations are passing and have addressed any issues that are present:

  • Yes

@SpeedyFireCyclone SpeedyFireCyclone requested review from a team as code owners May 6, 2026 09:16
@github-actions

github-actions Bot commented May 6, 2026

Copy link
Copy Markdown
Contributor

🔒 Security Approval Required

This fork PR requires manual approval before automated testing can run.

For security, a maintainer must:

  1. 📝 Review the code changes carefully
  2. Verify file types - This PR should only contain .yml, .yaml, or .json files. Check for any executable scripts (.ps1, .py, .sh, .exe, etc.) which are not allowed in this context.
  3. 🏷️ Add the SafeToRun label if the changes are safe to execute

Note: If new commits are added later, simply remove and re-add the SafeToRun label.


🤖 Automated security check • Created: 2026-05-06T09:24:13.075Z
Learn more: GitHub Security Lab - Preventing PWN Requests

@github-actions

github-actions Bot commented May 6, 2026

Copy link
Copy Markdown
Contributor

🔒 Security Approval Required

This fork PR requires manual approval before automated testing can run.

For security, a maintainer must:

  1. 📝 Review the code changes carefully
  2. Verify file types - This PR should only contain .yml, .yaml, or .json files. Check for any executable scripts (.ps1, .py, .sh, .exe, etc.) which are not allowed in this context.
  3. 🏷️ Add the SafeToRun label if the changes are safe to execute

Note: If new commits are added later, simply remove and re-add the SafeToRun label.


🤖 Automated security check • Created: 2026-05-06T09:46:57.944Z
Learn more: GitHub Security Lab - Preventing PWN Requests

@SpeedyFireCyclone SpeedyFireCyclone marked this pull request as draft May 6, 2026 11:04
@SpeedyFireCyclone SpeedyFireCyclone marked this pull request as draft May 6, 2026 11:04
@SpeedyFireCyclone SpeedyFireCyclone changed the title [ASIM] Authentication - Salesforce Service Cloud - SalesforceServiceCloudV2_CL table support [ASIM] Authentication - Salesforce Service Cloud - Codeless Connector Tables Support May 6, 2026
@SpeedyFireCyclone SpeedyFireCyclone marked this pull request as ready for review May 6, 2026 11:50
@github-actions

github-actions Bot commented May 6, 2026

Copy link
Copy Markdown
Contributor

🔒 Security Approval Required

This fork PR requires manual approval before automated testing can run.

For security, a maintainer must:

  1. 📝 Review the code changes carefully
  2. Verify file types - This PR should only contain .yml, .yaml, or .json files. Check for any executable scripts (.ps1, .py, .sh, .exe, etc.) which are not allowed in this context.
  3. 🏷️ Add the SafeToRun label if the changes are safe to execute

Note: If new commits are added later, simply remove and re-add the SafeToRun label.


🤖 Automated security check • Created: 2026-05-06T11:55:14.497Z
Learn more: GitHub Security Lab - Preventing PWN Requests

@v-atulyadav v-atulyadav added the SafeToRun This is used only for ASim parsers Fork PR Pipeline run. label May 26, 2026
@v-atulyadav

Copy link
Copy Markdown
Collaborator

Hi @SpeedyFireCyclone,
Please check for failed KQL validation as well as any branch conflicts. Thanks

@v-atulyadav

Copy link
Copy Markdown
Collaborator

Hi @SpeedyFireCyclone,

Please review the comments above and take the necessary action accordingly. Thanks

@v-atulyadav

Copy link
Copy Markdown
Collaborator

Hi @SpeedyFireCyclone,
Please resolve the branch conflicts. Thanks

@v-atulyadav v-atulyadav removed the SafeToRun This is used only for ASim parsers Fork PR Pipeline run. label Jun 8, 2026
@v-atulyadav v-atulyadav requested a review from Copilot June 8, 2026 10:14
@v-atulyadav v-atulyadav added the SafeToRun This is used only for ASim parsers Fork PR Pipeline run. label Jun 8, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds support for newer Salesforce Service Cloud connector tables (V2/V3) in the ASIM Authentication Salesforce parsers, and wires a new pack parameter through the unifying parsers/ARM templates to optionally emit packed AdditionalFields.

Changes:

  • Update Salesforce Service Cloud parsers to read from SalesforceServiceCloud_CL, SalesforceServiceCloudV2_CL, and SalesforceServiceCloudV3_CL.
  • Add a pack: bool parameter to Salesforce Service Cloud parsers and propagate it through imAuthentication / ASimAuthentication and ARM deployments.
  • Refresh schema/data test baselines and update changelogs.

Reviewed changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
Parsers/ASimAuthentication/Parsers/vimAuthenticationSalesforceSC.yaml Adds V2/V3 union + pack support and updated normalization logic for filtering parser
Parsers/ASimAuthentication/Parsers/ASimAuthenticationSalesforceSC.yaml Adds V2/V3 union + pack support for non-filtering parser
Parsers/ASimAuthentication/Parsers/imAuthentication.yaml Passes pack through to vimAuthenticationSalesforceSC
Parsers/ASimAuthentication/Parsers/ASimAuthentication.yaml Passes pack through to ASimAuthenticationSalesforceSC
Parsers/ASimAuthentication/ARM/vimAuthenticationSalesforceSC/vimAuthenticationSalesforceSC.json Updates deployed function KQL + adds pack parameter
Parsers/ASimAuthentication/ARM/vimAuthenticationSalesforceSC/README.md Updates ARM README description for supported tables
Parsers/ASimAuthentication/ARM/imAuthentication/imAuthentication.json Updates deployed unifying function to pass pack into Salesforce SC filtering parser
Parsers/ASimAuthentication/ARM/ASimAuthenticationSalesforceSC/ASimAuthenticationSalesforceSC.json Updates deployed function KQL + adds pack parameter
Parsers/ASimAuthentication/ARM/ASimAuthenticationSalesforceSC/README.md Updates ARM README description for supported tables
Parsers/ASimAuthentication/ARM/ASimAuthentication/ASimAuthentication.json Updates deployed unifying function to pass pack into Salesforce SC ASim parser
Parsers/ASimAuthentication/CHANGELOG/vimAuthenticationSalesforceSC.md Changelog entry for v0.2.0 connector table support
Parsers/ASimAuthentication/CHANGELOG/ASimAuthenticationSalesforceSC.md Changelog entry for v0.2.0 connector table support
Parsers/ASimAuthentication/CHANGELOG/imAuthentication.md Changelog entry for v0.3.13 pack propagation
Parsers/ASimAuthentication/CHANGELOG/ASimAuthentication.md Changelog entry for v0.2.16 pack propagation
Parsers/ASimAuthentication/Tests/Salesforce_Service Cloud_vimAuthentication_SchemaTest.csv Updates expected schema-validation output for filtering parser
Parsers/ASimAuthentication/Tests/Salesforce_Service Cloud_vimAuthentication_DataTest.csv Adds new data-validation baseline for filtering parser
Parsers/ASimAuthentication/Tests/Salesforce_Service Cloud_ASimAuthentication_SchemaTest.csv Updates expected schema-validation output for ASim parser
Parsers/ASimAuthentication/Tests/Salesforce_Service Cloud_ASimAuthentication_DataTest.csv Adds new data-validation baseline for ASim parser
.script/tests/KqlvalidationsTests/CustomTables/SalesforceServiceCloud_CL.json Expands mocked custom table schema used by KQL validation tests

Comment thread Parsers/ASimAuthentication/Parsers/vimAuthenticationSalesforceSC.yaml Outdated
Comment thread Parsers/ASimAuthentication/Parsers/vimAuthenticationSalesforceSC.yaml Outdated
Comment thread Parsers/ASimAuthentication/Parsers/vimAuthenticationSalesforceSC.yaml Outdated
Application = TargetAppName,
EventStartTime = TimeGenerated,
EventEndTime = TimeGenerated
| extend ParsedHttpUserAgent = parse_user_agent(HttpUserAgent, "os").OperatingSystem
@v-atulyadav v-atulyadav added SafeToRun This is used only for ASim parsers Fork PR Pipeline run. and removed SafeToRun This is used only for ASim parsers Fork PR Pipeline run. labels Jun 8, 2026
@v-atulyadav

Copy link
Copy Markdown
Collaborator

Hi @SpeedyFireCyclone,

Please review Copilot’s suggestions above and take the necessary action accordingly. Thanks

@SpeedyFireCyclone

Copy link
Copy Markdown
Contributor Author

Abandoned in favor of #14423

@yummyblabla yummyblabla added SafeToRun This is used only for ASim parsers Fork PR Pipeline run. and removed SafeToRun This is used only for ASim parsers Fork PR Pipeline run. labels Jun 25, 2026

@yummyblabla yummyblabla left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kqlvalidations failing due to missing _ItemId in V2 and V3 of the table. Should be straightforward to add.
{
"Name": "_ItemId",
"Type": "String"
}

Template validation is failing. Please fix so that it will the testers. I can run the testers manually if the testers fail to run.

Otherwise, parsers look good.

Comment thread Parsers/ASimAuthentication/Parsers/vimAuthenticationSalesforceSC.yaml Outdated
@yummyblabla yummyblabla added SafeToRun This is used only for ASim parsers Fork PR Pipeline run. and removed SafeToRun This is used only for ASim parsers Fork PR Pipeline run. labels Jun 26, 2026
@yummyblabla yummyblabla merged commit 111ad73 into Azure:master Jun 26, 2026
32 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ASIM SafeToRun This is used only for ASim parsers Fork PR Pipeline run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants