[ASIM] Authentication - Salesforce Service Cloud - Codeless Connector Tables Support#14215
Conversation
|
🔒 Security Approval Required This fork PR requires manual approval before automated testing can run. For security, a maintainer must:
Note: If new commits are added later, simply remove and re-add the 🤖 Automated security check • Created: 2026-05-06T09:24:13.075Z |
|
🔒 Security Approval Required This fork PR requires manual approval before automated testing can run. For security, a maintainer must:
Note: If new commits are added later, simply remove and re-add the 🤖 Automated security check • Created: 2026-05-06T09:46:57.944Z |
|
🔒 Security Approval Required This fork PR requires manual approval before automated testing can run. For security, a maintainer must:
Note: If new commits are added later, simply remove and re-add the 🤖 Automated security check • Created: 2026-05-06T11:55:14.497Z |
|
Hi @SpeedyFireCyclone, |
|
Please review the comments above and take the necessary action accordingly. Thanks |
|
Hi @SpeedyFireCyclone, |
… ASIM/AuthenticationSalesforceSC
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds support for newer Salesforce Service Cloud connector tables (V2/V3) in the ASIM Authentication Salesforce parsers, and wires a new pack parameter through the unifying parsers/ARM templates to optionally emit packed AdditionalFields.
Changes:
- Update Salesforce Service Cloud parsers to read from
SalesforceServiceCloud_CL,SalesforceServiceCloudV2_CL, andSalesforceServiceCloudV3_CL. - Add a
pack: boolparameter to Salesforce Service Cloud parsers and propagate it throughimAuthentication/ASimAuthenticationand ARM deployments. - Refresh schema/data test baselines and update changelogs.
Reviewed changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| Parsers/ASimAuthentication/Parsers/vimAuthenticationSalesforceSC.yaml | Adds V2/V3 union + pack support and updated normalization logic for filtering parser |
| Parsers/ASimAuthentication/Parsers/ASimAuthenticationSalesforceSC.yaml | Adds V2/V3 union + pack support for non-filtering parser |
| Parsers/ASimAuthentication/Parsers/imAuthentication.yaml | Passes pack through to vimAuthenticationSalesforceSC |
| Parsers/ASimAuthentication/Parsers/ASimAuthentication.yaml | Passes pack through to ASimAuthenticationSalesforceSC |
| Parsers/ASimAuthentication/ARM/vimAuthenticationSalesforceSC/vimAuthenticationSalesforceSC.json | Updates deployed function KQL + adds pack parameter |
| Parsers/ASimAuthentication/ARM/vimAuthenticationSalesforceSC/README.md | Updates ARM README description for supported tables |
| Parsers/ASimAuthentication/ARM/imAuthentication/imAuthentication.json | Updates deployed unifying function to pass pack into Salesforce SC filtering parser |
| Parsers/ASimAuthentication/ARM/ASimAuthenticationSalesforceSC/ASimAuthenticationSalesforceSC.json | Updates deployed function KQL + adds pack parameter |
| Parsers/ASimAuthentication/ARM/ASimAuthenticationSalesforceSC/README.md | Updates ARM README description for supported tables |
| Parsers/ASimAuthentication/ARM/ASimAuthentication/ASimAuthentication.json | Updates deployed unifying function to pass pack into Salesforce SC ASim parser |
| Parsers/ASimAuthentication/CHANGELOG/vimAuthenticationSalesforceSC.md | Changelog entry for v0.2.0 connector table support |
| Parsers/ASimAuthentication/CHANGELOG/ASimAuthenticationSalesforceSC.md | Changelog entry for v0.2.0 connector table support |
| Parsers/ASimAuthentication/CHANGELOG/imAuthentication.md | Changelog entry for v0.3.13 pack propagation |
| Parsers/ASimAuthentication/CHANGELOG/ASimAuthentication.md | Changelog entry for v0.2.16 pack propagation |
| Parsers/ASimAuthentication/Tests/Salesforce_Service Cloud_vimAuthentication_SchemaTest.csv | Updates expected schema-validation output for filtering parser |
| Parsers/ASimAuthentication/Tests/Salesforce_Service Cloud_vimAuthentication_DataTest.csv | Adds new data-validation baseline for filtering parser |
| Parsers/ASimAuthentication/Tests/Salesforce_Service Cloud_ASimAuthentication_SchemaTest.csv | Updates expected schema-validation output for ASim parser |
| Parsers/ASimAuthentication/Tests/Salesforce_Service Cloud_ASimAuthentication_DataTest.csv | Adds new data-validation baseline for ASim parser |
| .script/tests/KqlvalidationsTests/CustomTables/SalesforceServiceCloud_CL.json | Expands mocked custom table schema used by KQL validation tests |
| Application = TargetAppName, | ||
| EventStartTime = TimeGenerated, | ||
| EventEndTime = TimeGenerated | ||
| | extend ParsedHttpUserAgent = parse_user_agent(HttpUserAgent, "os").OperatingSystem |
|
Please review Copilot’s suggestions above and take the necessary action accordingly. Thanks |
|
Abandoned in favor of #14423 |
yummyblabla
left a comment
There was a problem hiding this comment.
Kqlvalidations failing due to missing _ItemId in V2 and V3 of the table. Should be straightforward to add.
{
"Name": "_ItemId",
"Type": "String"
}
Template validation is failing. Please fix so that it will the testers. I can run the testers manually if the testers fail to run.
Otherwise, parsers look good.
Required items, please complete
Change(s):
packparameter for the updated parserReason for Change(s):
Version Updated:
Testing Completed:
Checked that the validations are passing and have addressed any issues that are present: