mavgen_python: Check reset buffer logic even if a message is generated#131
Merged
Merged
Conversation
Contributor
Author
|
Any feedback on this fix would be greatly appreciated. |
Contributor
|
I have an application that runs 24/7 so I'll test this one. |
Contributor
Author
|
Thanks. It's very unlikely to be a problem unless you are receiving via a
very reliable connection e.g. TCP localhost.
…On Fri., 2 Nov. 2018, 8:51 pm Amilcar Lucas, ***@***.***> wrote:
I have an application that runs 24/7 so I'll test this one.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#131 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AH6BeP7FU6wEXA0QcW5iYoRpwo3nXX3rks5urBWegaJpZM4Q4ybv>
.
|
Contributor
|
I do have a cable based TCP connection :( |
|
The issue this PR addresses is still present in current versions of pymavlink, and the proposed fix does seem to address it. |
peterbarker
force-pushed
the
memory_leak_fix
branch
2 times, most recently
from
12cb8c0 to
d6b2763
Compare
Contributor
|
I have rebased this change and force-pushed. Will merge after a bit of testing. |
peterbarker
force-pushed
the
memory_leak_fix
branch
from
d6b2763 to
2094b54
Compare
Contributor
|
Merged it. Thanks @SamuelDudley - it did take us a while! |
Contributor
Author
|
Thanks @peterbarker for carrying this over the line... I have a lot less hair than when I submitted this PR 🤣 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #130