Use binary encoding in tx-validation#449
Open
Drop-Table-Users wants to merge 1 commit into
Open
Conversation
Drop-Table-Users
force-pushed
the
tx-validation-binary
branch
from
d577a9f to
5b2d3ad
Compare
Drop-Table-Users
force-pushed
the
tx-validation-binary
branch
from
7e7af0c to
3a47748
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Okay, seems to be smaller now.
This 16,126B CBOR TX: https://github.com/Anastasia-Labs/midgard/pull/422/changes#diff-00ebaf9f7c4505f44f36d21cdeee21d79f6379de7b35008cd74ef33b688045deR4
Is currently 14,922B in binary: https://github.com/Anastasia-Labs/midgard/pull/449/changes#diff-5e8e969b35d547b876985e047ef6a6d092d032976f94efe987bbb3a358698f2cR1
Notes:
lucid-midgard/scripts/legacy-cbor-codecshould be dropped in the end -> it is there just so I could go back & forth from CBOR -> Binary -> CBOR